divmod-dev team mailing list archive

[Jean-Paul Calderone <exarkun@xxxxxxxxxxxxxxxxx>]

> It makes testing easier and more standard for the developer.

It doesn't do either of these.

> Since the 'tests_require' contains information about the tests requirements, anyone can run the tests without digging in the source code to know which libraries are required.

This can be addressed just as easily with an INSTALL or README file.

> And when the distribute/setuptools package is not installed, it imports from distutils and it behaves the same as before.

So there are now twice as many possible install outcomes, which makes debugging installation problems (at least) twice as hard.

> If the request is to split the merge proposal into 2 patches ... why not.

Yes, that's what I was requesting (so that I can only reject the setuptools change while not rejecting the unittest2 change).

> For me, they are complementary changes to improve testing, so it makes sense to propose them together.

Many, many, many, many changes are complementary.  That doesn't mean they should be made simultaneously.  Changesets should focus on one change, not many complementary changes.  Basically, the smallest useful change is what you should try to make.  That way issues with *unrelated* changes don't hold up useful improvements, reviews are easier, the history is easier to navigate, tickets can have simple descriptions, and problems that require changes to be reverted don't also revert working functionality.
-- 
https://code.launchpad.net/~florent.x/pyflakes/1097061-unittest2/+merge/142224
Your team Divmod-dev is requested to review the proposed merge of lp:~florent.x/pyflakes/1097061-unittest2 into lp:pyflakes.