← Back to team overview

dolfin team mailing list archive

Re: Added class Synchronizer to associate time with an object. BoundaryCondtion derives Syncronizer. \"time\" functions have been removed from BoundaryCondition.

 

Looks good, but could we change the name? Synchronizer sounds like
something responsible for synchronizing other things. My suggestion
would be Synchronized, Synchronizable or TimeDependent. (Compare base
classes/interfaces in Java: Editable, Adjustable, Comparable,
Serializable etc.)

Another suggestion is to remove bool time_set and make sure real* t is
null when not specified (just check if ( !t )).

/Anders

On Fri, Sep 02, 2005 at 07:30:56PM +0200, dolfin@xxxxxxxxxx wrote:
> Commit from garth (2005-09-02 19:30 CEST)
> -----------------
> 
> Added class Synchronizer to associate time with an object. BoundaryCondtion derives Syncronizer. "time" functions have been removed from BoundaryCondition.
> 
>   dolfin  Makefile.in                                        1.101
>   dolfin  aclocal.m4                                         1.128
>   dolfin  configure                                          1.194
>   dolfin  src/Makefile.in                                    1.102
>   dolfin  src/config/Makefile.in                             1.105
>   dolfin  src/demo/Makefile.in                               1.107
>   dolfin  src/demo/bench/Makefile.in                         1.28
>   dolfin  src/demo/fem/Makefile.in                           1.6
>   dolfin  src/demo/solvers/Makefile.in                       1.100
>   dolfin  src/demo/solvers/navierstokes/Makefile.in          1.69
>   dolfin  src/demo/solvers/ode/Makefile.in                   1.86
>   dolfin  src/demo/solvers/ode/homotopy/Makefile.in          1.31
>   dolfin  src/demo/solvers/ode/modeling/Makefile.in          1.58
>   dolfin  src/greeting/Makefile.in                           1.85
>   dolfin  src/kernel/Makefile.in                             1.101
>   dolfin  src/kernel/common/Makefile.am                      1.20
>   dolfin  src/kernel/common/Makefile.in                      1.104
> + dolfin  src/kernel/common/Synchronizer.cpp                 1.1
>   dolfin  src/kernel/common/dolfin/Makefile.am               1.14
>   dolfin  src/kernel/common/dolfin/Makefile.in               1.98
> + dolfin  src/kernel/common/dolfin/Synchronizer.h            1.1
>   dolfin  src/kernel/common/dolfin/dolfin_common.h           1.13
>   dolfin  src/kernel/fem/BoundaryCondition.cpp               1.4
>   dolfin  src/kernel/fem/Makefile                            1.284
>   dolfin  src/kernel/fem/Makefile.in                         1.112
>   dolfin  src/kernel/fem/dolfin/BoundaryCondition.h          1.11
>   dolfin  src/kernel/fem/dolfin/Makefile.in                  1.111
>   dolfin  src/kernel/form/Makefile.in                        1.83
>   dolfin  src/kernel/form/dolfin/Makefile.in                 1.83
>   dolfin  src/kernel/function/Makefile.in                    1.75
>   dolfin  src/kernel/function/dolfin/Makefile.in             1.75
>   dolfin  src/kernel/io/Makefile.in                          1.108
>   dolfin  src/kernel/io/dolfin/Makefile.in                   1.102
>   dolfin  src/kernel/la/Makefile.in                          1.110
>   dolfin  src/kernel/la/dolfin/Makefile.in                   1.107
>   dolfin  src/kernel/log/Makefile.in                         1.92
>   dolfin  src/kernel/log/dolfin/Makefile.in                  1.92
>   dolfin  src/kernel/main/Makefile.in                        1.102
>   dolfin  src/kernel/main/dolfin/Makefile.in                 1.97
>   dolfin  src/kernel/math/Makefile.in                        1.93
>   dolfin  src/kernel/math/dolfin/Makefile.in                 1.92
>   dolfin  src/kernel/mesh/Makefile.in                        1.79
>   dolfin  src/kernel/mesh/dolfin/Makefile.in                 1.78
>   dolfin  src/kernel/ode/Makefile.in                         1.104
>   dolfin  src/kernel/ode/dolfin/Makefile.in                  1.101
>   dolfin  src/kernel/quadrature/Makefile.in                  1.94
>   dolfin  src/kernel/quadrature/dolfin/Makefile.in           1.94
>   dolfin  src/kernel/settings/Makefile.in                    1.87
>   dolfin  src/kernel/settings/dolfin/Makefile.in             1.87
>   dolfin  src/modules/Makefile.in                            1.109
>   dolfin  src/modules/convdiff/Makefile.in                   1.104
>   dolfin  src/modules/convdiff/dolfin/Makefile.in            1.31
>   dolfin  src/modules/dolfin/Makefile.in                     1.31
>   dolfin  src/modules/elasticity/Makefile.in                 1.67
>   dolfin  src/modules/elasticity/dolfin/Makefile.in          1.19
>   dolfin  src/modules/elasticity-updated/Makefile.in         1.52
>   dolfin  src/modules/elasticity-updated/dolfin/Makefile.in  1.14
>   dolfin  src/modules/navierstokes/Makefile.in               1.101
>   dolfin  src/modules/navierstokes/dolfin/Makefile.in        1.30
>   dolfin  src/modules/poisson/Makefile.in                    1.103
>   dolfin  src/modules/poisson/dolfin/Makefile.in             1.32
>   dolfin  src/post/Makefile.in                               1.88
>   dolfin  src/pre/Makefile.in                                1.96
>   dolfin  src/utils/Makefile.in                              1.99
>   dolfin  src/utils/inp2dx/Makefile.in                       1.99
> 
> _______________________________________________
> DOLFIN-dev mailing list
> DOLFIN-dev@xxxxxxxxxx
> http://www.fenics.org/cgi-bin/mailman/listinfo/dolfin-dev
> 

-- 
Anders Logg
Research Assistant Professor
Toyota Technological Institute at Chicago
http://www.tti-c.org/logg/



Follow ups

References