dolfin team mailing list archive

["Johan Hoffman" <jhoffman@xxxxxxxxxxx>]

> On Fri, Nov 11, 2005 at 03:11:05PM +0100, Johan Hoffman wrote:
>>
>> >> Also, would it be an idea to change the name of the class GMRES to
>> >> KrylovSolver,
>> >> and provide functions to allow the user to set the exact method and
>> >> preconditioner. The default would be to use the PETSc default (GMRES
>> +
>> >> some
>> >> preconditioner) as we do now in the class GMRES.
>> >
>> > Yes, that's probably better. Let's make a class KrylovSolver to
>> > replace the current GMRES. And let's also create a new class GMRES
>> > that specifically does GMRES, but where solve() is static:
>> >
>> >     GMRES::solve(A, x, b);
>> >
>> > This function would just create a KrylovSolver object and call it.
>>
>> Yes, a Krylovsolver class is better. I guess the idea would then be to
>> put
>> all PETSc stuff in the KryolvSolver class, or should it be PETSc in the
>> GMRES class as well?
>
> Yes, put all PETSc stuff in KrylovSolver so we don't have to see it.
> GMRES just needs to call KrylovSolver and doesn't need to know about
> PETSc.

Sounds good. Then we can keep the GMRES class clean and user friendly.

/Johan