dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Dec 06, 2005 at 08:19:41AM +0100, Johan Hoffman wrote:

> > If someone wants to use PETSc calls, they can always ask for the
> > KSP pointer. Maybe one policy would be that the only thing from PETSc
> > that is visible is that you can ask for the Mat pointer and Vec
> > pointer etc, but nothing else?
> 
> I agree, it should be easy to add/change interface to other LA packages.

Great. Let's try to keep to the following policy then: the only part
of PETSc that is visible outside of src/kernel/la is the function
Matrix::mat(), Vector::vec() etc.

> >> > As you see, we have not been very consistent with capitalization
> >> > of the identifiers. Any thoughts on this? The current standard seems
> >> > to be that we don't capitalize at all. We used to capitalize
> >> > everything (XML, MATLAB, TRIANGLE) etc but I thought it was ugly so I
> >> > changed.
> >>
> >> I don't like all caps. It's ugly and reminds me of old FORTRAN code.
> >
> > ok, so everything lower-case?
> 
> Fine by me.

ok. Let's try to keep to that (including fixing all previous enums
that don't follow this standard).

I have a suggestion for the enums in KrylovSolver. Can we move
PreconditionerType to the class Preconditioner? Then we can rename it
to just Type and same for SolverType, so that we have the following
two enum types:

    KrylovSolver::Type
    Preconditioner::Type

/Anders