dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Jun 10, 2008 at 09:55:51AM +0200, Martin Sandve Alnæs wrote:
> 2008/6/9 DOLFIN <dolfin@xxxxxxxxxx>:
> > One or more new changesets pushed to the primary dolfin repository.
> > A short summary of the last three changesets is included below.
> >
> > changeset:   4282:5f6759a7460d81435abf4d67911667e3e628e164
> > tag:         tip
> > user:        Anders Logg <logg@xxxxxxxxx>
> > date:        Mon Jun 09 23:06:51 2008 +0200
> > files:       dolfin/fem/Assembler.cpp dolfin/fem/UFC.cpp dolfin/fem/UFC.h
> > description:
> > Reset local tensor A^K before call to tabulate_tensor()
> 
> Why? This is the job of tabulate_tensor, which can do it much more efficiently?

I added this for convenience. It is used when assembling forms over
subdomains and the form compiler needs to generate code for zero
contributions from other domains, for example when integrating

  M = f*ds(5)

Then the compiler needs to add zero integrals for ds([0-4]).
Then this code just needs to be empty.

I'm not sure that the overhead is big, but I've removed it. I agree
it's the job of the form compiler to generate the code that zeros the
tensor, even if it would be nice to assume that the argument that
comes in to tabulate_tensor is always zero.

-- 
Anders

Attachment: signature.asc
Description: Digital signature