dolfin team mailing list archive

["Johannes Ring" <johannr@xxxxxxxxx>]

On Fri, June 20, 2008 Anders Logg wrote:
> On Fri, Jun 20, 2008 at 04:18:02PM +0200, Johannes Ring wrote:
>> I also got the following error when compiling DOLFIN in Windows:
>>
>> g++-sjlj -o dolfin\mesh\ALE.o -c -Wall -pipe -ansi -DDEBUG -g -Werror
>> -DNDEBUG -O2 -DPACKAGE_VERSION=\"0.7.3\" -I. -IC:\local\include
>> -IC:\boost_1_35_0 -IC:\local\include\libxml dolfin\mesh\ALE.cpp
>> dolfin\mesh\ALE.cpp: In static member function 'static void
>> dolfin::ALE::hermiteFunction(dolfin::real**, dolfin::uint,
>> dolfin::Mesh&,
>> dolfin::Mesh&, const dolfin::MeshFunction<unsigned int>&, const
>> dolfin::MeshFunction<unsigned int>&)':
>> dolfin\mesh\ALE.cpp:247: error: 'M_PI' was not declared in this scope
>> scons: *** [dolfin\mesh\ALE.o] Error 1
>> scons: building terminated because of errors.
>>
>> Including math.h in ALE.cpp doesn't help, so I simply defined M_PI
>> explicitly:
>>
>> #ifndef M_PI
>> #define M_PI 3.14159265358979323846
>> #endif
>>
>> There are probably better ways, but it's a quick fix (patch is
>> attached).
>>
>> Johannes
>
> It's already defined in dolfin/common/constants.h so I changed from
> M_PI to DOLFIN_PI.

Okay, I didn't know that. Great!

Johannes