← Back to team overview

dolfin team mailing list archive

Re: [Branch ~dolfin-core/dolfin/main] Rev 4658: Remove arguments in header files when not used. Error reported by Benjamin

 

>
>
> On 26/03/10 05:28, noreply@xxxxxxxxxxxxx wrote:
>> ------------------------------------------------------------
>> revno: 4658
>> committer: Anders Logg<logg@xxxxxxxxx>
>> branch nick: dolfin-dev
>> timestamp: Thu 2010-03-25 22:23:54 +0100
>> message:
>>    Remove arguments in header files when not used. Error reported by
>> Benjamin
>>    while compiling MeshBuilder. Unclear why these errors only show up
>> when
>>    building MeshBuilder. Can be suppressed with -Wno-unused-parameter
>> but
>>    that flag is not used.
>
> This breaks the consistency with which we declare functions. Why does
> Benjamin run into a error/warning and the rest of us don't?

Yes, it is strange. The warnings have the form

cc1plus: warnings being treated as errors
In file included from
/home/benjamik/fenics/dolfin/local/include/dolfin/la/dolfin_la.h:11,
                 from /home/benjamik/fenics/dolfin/local/include/dolfin.h:10,
                 from ./scenegraph/OsgDolfinObject.h:5,
                 from scenegraph/OsgDolfinObject.cpp:11:
/home/benjamik/fenics/dolfin/local/include/dolfin/la/GenericTensor.h:109:
error: unused parameter ‘x

and I get them only when building Meshbuilder. The compiler is the
standard g++ 4.4.1.

Benjamin



>
> Garth
>
>
>> modified:
>>    dolfin/common/NoDeleter.h
>>    dolfin/fem/BasisFunction.h
>>    dolfin/la/GenericTensor.h
>>    dolfin/la/GenericVector.h
>>    dolfin/la/STLMatrix.h
>>    dolfin/la/Scalar.h
>>    dolfin/la/uBLASMatrix.h
>>    dolfin/la/uBLASPreconditioner.h
>>    dolfin/la/uBLASVector.h
>>    dolfin/mesh/DomainBoundary.h
>>    dolfin/mesh/SubDomain.h
>>    dolfin/nls/NonlinearProblem.h
>>    dolfin/ode/dGqMethod.h
>>
>>
>> --
>> lp:dolfin
>> https://code.launchpad.net/~dolfin-core/dolfin/main
>>
>> Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
>> To unsubscribe from this branch go to
>> https://code.launchpad.net/~dolfin-core/dolfin/main/+edit-subscription.
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp
>





Follow ups

References