dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Aug 24, 2010 at 03:35:49AM -0000, marc spiegelman wrote:
> Public bug reported:
>
> more fun with cmake
> seems to find zlib but doesn't set -DHAS_ZLIB and appropriate libraries (breaks compressed vtk files)
>
> in dolfin/dolfin/CMakeLists.txt is
>
> # ZLIB
> if (DOLFIN_ENABLE_ZLIB AND DOLFIN_ZLIB_FOUND)
>   list(APPEND DOLFIN_CXX_DEFINITIONS "-DHAS_ZLIB")
>   list(APPEND DOLFIN_INCLUDE_DIRECTORIES ${DOLFIN_ZLIB_INCLUDE_DIRS})
>   list(APPEND DOLFIN_TARGET_LINK_LIBRARIES ${DOLFIN_ZLIB_LIBS})
> endif()
>
> should probably be:
> #ZLIB
> if (DOLFIN_ENABLE_ZLIB AND ZLIB_FOUND)
>   list(APPEND DOLFIN_CXX_DEFINITIONS "-DHAS_ZLIB")
>   list(APPEND DOLFIN_INCLUDE_DIRECTORIES ${ZLIB_INCLUDE_DIRS})
>   list(APPEND DOLFIN_TARGET_LINK_LIBRARIES ${ZLIB_LIBRARIES})
> endif()
>
> just enjoying cmake so much ;)
>
> ** Affects: dolfin
>      Importance: Undecided
>          Status: New

Fixed! Thanks for noticing.

--
Anders

-- 
CMake ZLIB bug (affects compressed vtk files)
https://bugs.launchpad.net/bugs/623121
You received this bug notification because you are a member of DOLFIN
Team, which is subscribed to DOLFIN.

Status in DOLFIN: Fix Committed

Bug description:
more fun with cmake 
seems to find zlib but doesn't set -DHAS_ZLIB and appropriate libraries (breaks compressed vtk files)

in dolfin/dolfin/CMakeLists.txt is

# ZLIB
if (DOLFIN_ENABLE_ZLIB AND DOLFIN_ZLIB_FOUND)
  list(APPEND DOLFIN_CXX_DEFINITIONS "-DHAS_ZLIB")
  list(APPEND DOLFIN_INCLUDE_DIRECTORIES ${DOLFIN_ZLIB_INCLUDE_DIRS})
  list(APPEND DOLFIN_TARGET_LINK_LIBRARIES ${DOLFIN_ZLIB_LIBS})
endif()

should probably be:
#ZLIB
if (DOLFIN_ENABLE_ZLIB AND ZLIB_FOUND)
  list(APPEND DOLFIN_CXX_DEFINITIONS "-DHAS_ZLIB")
  list(APPEND DOLFIN_INCLUDE_DIRECTORIES ${ZLIB_INCLUDE_DIRS})
  list(APPEND DOLFIN_TARGET_LINK_LIBRARIES ${ZLIB_LIBRARIES})
endif()

just enjoying cmake so much ;)