dolfin team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Feb 01, 2011 at 12:54:07PM -0000, Johannes Ring wrote:
> OK! Problem is that DOLFIN_VERSION is already defined in
> dolfin/common/constants.h so DOLFIN won't compile if we just replace
> PACKAGE_VERSION with DOLFIN_VERSION. The best would probably be to
> rename constants.h to constant.h.in and have CMake generate constants.h
> with the correct DOLFIN version. Then we could remove the problematic
> -DPACKAGE_VERSION flag from dolfin.pc and dolfin-config.cmake. However,
> I tried this not so long ago and it turned out to be somewhat involved
> because of the generate scripts under dolfin/swig. I will look at it
> again.
>
> ** Changed in: dolfin
>        Status: New => In Progress

What if we just DOLFIN_VERSION=PACKAGE_VERSION from remove constants.h
and just rely on the compiler flag -DDOLFIN_VERSION=0.9.x in all
places where we currently have DOLFIN_VERSION in the code?

--
Anders

-- 
You received this bug notification because you are a member of DOLFIN
Team, which is subscribed to DOLFIN.
https://bugs.launchpad.net/bugs/711156

Title:
  DOLFIN pollutes namespace with PACKAGE_VERSION in CXXFLAGS

Status in DOLFIN:
  In Progress

Bug description:
  
  PACKAGE_VERSION should not be leaked into dolfin.pc. It gives a lot of warnings within autotools based projects based on DOLFIN.