dolfin team mailing list archive

[Johan Hake <johan.hake@xxxxxxxxx>]

On Wednesday May 4 2011 00:40:02 B. Emek Abali wrote:
> Question #153448 on DOLFIN changed:
> https://answers.launchpad.net/dolfin/+question/153448
> 
> B. Emek Abali posted a new comment:
> hi Johan,
> 
> sorry about not knowing the jargon of diff or patch, so I thought you
> wish to SEE the difference, ok lets try it so:

Yes, I would very much like to see the changes and thank you for these. The 
problem is to implement them into meshconverter, so more people benefit from 
them. As the difference are so large I wont manually update meshconverter with 
your changes. 

A 'diff' is a line by line difference between two files generated by the unix 
program diff. The result of such a call is often refered to as a diff.

  http://en.wikipedia.org/wiki/Diff

The cool thing with diffs are that these can be applied directly to the 
original file and the file will be changed to the new one.

So if it would be possible to apply your changes to the original 
meshconverter.py script and then take a diff of that against the unchanged 
meshconverter script I would be very happy!

  diff new_meshconverter.py new_meshconverter.py > \
      dolfin_Emek_2011.05.04.diff

You can also look at for more elaborated ways of creating a patch:

  http://fenicsproject.org/developer/developer.html#contributing-code

Also if you want to be included as co-author on the meshconverter script you 
need to fill out these two forms:

  http://fenicsproject.org/pub/copyright/forms

and _snail mail_ them to the correct adress.

Best regards,

Johan

> I did one small model in Abaqus by drawing parts, making one instance,
> partitioning them into sections and adding two different materials into
> these sections, the file : for_JohanHake.inp is the output from Abaqus
> 6.8 (will not work with meshconverter.py )
> 
> The script abaqus2xml.py has only _abaqus(...) method (which I
> manipulated) and some handler needed methods (which I just copied), all
> the rest is not included.
> 
> both of them under www.lkm.tu-berlin.de/computational_reality
> 
> pls. tell me if you got the .inp file so I can delete it from there.

Got it!

Johan