dolfin team mailing list archive

["Marie E. Rognes" <meg@xxxxxxxxx>]

It also happens to not build for me:

[  2%] Building CXX object dolfin/CMakeFiles/dolfin.dir/la/STLMatrix.cpp.o
cc1plus: warnings being treated as errors
/home/meg/local/fenics/src/dolfin/trunk/dolfin/io/XMLLocalMeshData.cpp: 
In member function ‘void dolfin::XMLLocalMeshData::read_array(const 
xmlChar*, const xmlChar**)’:
/home/meg/local/fenics/src/dolfin/trunk/dolfin/io/XMLLocalMeshData.cpp:396:21: 
error: ‘xml_array’ may be used uninitialized in this function
make[2]: *** [dolfin/CMakeFiles/dolfin.dir/io/XMLLocalMeshData.cpp.o] 
Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [dolfin/CMakeFiles/dolfin.dir/all] Error 2
make: *** [all] Error 2

--
Marie



On 05/30/2011 03:47 PM, Garth N. Wells wrote:
> More helpful comments are requires too. I can't follow the code as it it
> no. This was requested when the merge request was marked as requiring
> fixing.
>
> Garth
>
> On 30/05/11 14:41, Garth N. Wells wrote:
> > > From a quick look, this code needs some fixes:
> >
> >   - Remove use of 'new' with plain pointers. We've made an effort to
> > remove 'new' from throughout the library.
> >
> >   - Use the DOLFIN convention for one line control statements
> >
> >   - Use more meaningful names (something better than, for example,
> > glob2loc, lci)
> >
> >   - Do not use MeshData for parallel data
> >
> >   - There are missing check on pointers which may lead to memory leaks.
> >
> > Garth
> >
> >
> > On 30/05/11 14:30, noreply@xxxxxxxxxxxxx wrote:
> > > ------------------------------------------------------------
> > > revno: 5902
> > > committer: Kent-Andre Mardal<kent-and@xxxxxxxxx>
> > > branch nick: dolfin
> > > timestamp: Mon 2011-05-30 15:27:52 +0200
> > > message:
> > >    minor cleanup
> > > modified:
> > >    test/unit/bc-indicators/python/aneurysm.py
> > >
> > >
> > > --
> > > lp:dolfin
> > > https://code.launchpad.net/~dolfin-core/dolfin/main
> > >
> > > Your team DOLFIN Core Team is subscribed to branch lp:dolfin.
> > > To unsubscribe from this branch go to https://code.launchpad.net/~dolfin-core/dolfin/main/+edit-subscription
> >
> >
> > _______________________________________________
> > Mailing list: https://launchpad.net/~dolfin
> > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~dolfin
> > More help   : https://help.launchpad.net/ListHelp
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dolfin
> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dolfin
> More help   : https://help.launchpad.net/ListHelp