← Back to team overview

dolfin team mailing list archive

Re: [Branch ~dolfin-core/dolfin/logg] Rev 6153: Add set_marker function to both MeshFunction and MeshMarkers to make

 

On Wednesday August 31 2011 23:16:15 Anders Logg wrote:
> On Wed, Aug 31, 2011 at 03:16:23PM -0700, Johan Hake wrote:
> > Disclaimer: I have no clue of what you are doing :)
> :
> :-) I'm trying to get boundary indicators working again (in
> 
> parallel). In the process, I'm making some changes and extensions that
> were suggested (not using MeshData as primary storage). The changes
> involve the addition of two new classes: MeshDomains and MeshMarkers
> (used internally by MeshDomains but also useful in itself). Will
> describe this all in more detail once it's working.

Ok.
 
> >   If you want to expose 'set' to Python you rather choose another name...
> >   
> >   set_one, set_value?
> 
> I suspected as much but couldn't figure out why. So why?

Well, it is probably not that bad after all. I just recall set not beeing used 
because it is a reserved word in Python in matplotlib. But it looks like it 
has changed to actually using set (resembles set in matlab), instead of setp 
which they had previously...

> The important point is not the set function but the set_marker
> function that needs to exist in both MeshFunction and MeshMarkers to
> get a template function to run with both so we avoid reimplementation
> of that function. Then it felt natural to add a set function as well.

Ok.

Johan

> --
> Anders
> 
> > Johan
> > 
> > On Wednesday August 31 2011 14:02:14 noreply@xxxxxxxxxxxxx wrote:
> > > ------------------------------------------------------------
> > > revno: 6153
> > > committer: Anders Logg <logg@xxxxxxxxx>
> > > branch nick: work
> > > timestamp: Wed 2011-08-31 23:00:04 +0200
> > > 
> > > message:
> > >   Add set_marker function to both MeshFunction and MeshMarkers to make
> > >   templated application of markers in SubDomains work with both.
> > > 
> > > modified:
> > >   dolfin/mesh/MeshFunction.h
> > >   dolfin/mesh/MeshMarkers.h
> > >   dolfin/mesh/SubDomain.cpp
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~dolfin
> > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~dolfin
> > More help   : https://help.launchpad.net/ListHelp


Follow ups

References