dolfin team mailing list archive

[Johan Hake <johan.hake@xxxxxxxxx>]

There is no explicit support for DOLFIN in instant, and tehre shouldn't be. 

I think the best way is to create a general cmake equivalent of 
header_and_libs_from_pkgconfig. Then let the VTK specific parts in instant use 
that. This has the benefit of others being able to use it with there own 
packages. 

Then we can provide a general 

  header_and_libs(package, ..., config_system="pkg-config")

function which provide all compile information we need for a certain package 
using any of "pkg-config" or "CMake" as config_system (or what ever) 
arguments.

Johan

On Monday September 26 2011 10:42:57 Kent-Andre Mardal wrote:
> It was made for VTK etc so it does not support Dolfin just yet. But it
> works well
> with VTK. Shouldn´t be to hard to add Dolfin, I think (if it is wanted).
> 
> Kent
> 
> On 26 September 2011 19:34, Johan Hake <johan.hake@xxxxxxxxx> wrote:
> > On Monday September 26 2011 10:28:44 Kent-Andre Mardal wrote:
> > > Instant has cmake support if you decide to switch.
> > 
> > It does not look like it. What we need is a cmake equivalent of:
> >  header_and_libs_from_pkgconfig
> > 
> > which I cannot see there is.
> > 
> > Johan
> > 
> > > Kent
> > > 
> > > On 26 September 2011 17:12, Johan Hake <johan.hake@xxxxxxxxx> wrote:
> > > > Fine with me, but do not throw away the pkg-config file. We use it
> > > > for JIT compilations.
> > > > 
> > > > Johan
> > > > 
> > > > On Monday September 26 2011 06:43:08 Johannes Ring wrote:
> > > > > On Fri, Sep 23, 2011 at 8:19 PM, Garth N. Wells <gnw20@xxxxxxxxx>
> > 
> > wrote:
> > > > > > Does/should DOLFIN use
> > > > > > 
> > > > > >  ufc-config.cmake
> > > > > > 
> > > > > > or
> > > > > > 
> > > > > >  ufc-1.pc
> > > > > > 
> > > > > > to find UFC?
> > > > > > 
> > > > > > It's a bit confusing since we have module
> > > > > > 
> > > > > >  FindUFC.cmake
> > > > > > 
> > > > > > which used pkg-config.
> > > > > 
> > > > > Yes, I think we should remove FindUFC.cmake and use
> > > > > ufc-config.cmake instead. We might then need to set UFC_DIR [1]
> > > > > when building DOLFIN since UFC no longer will be searched for in
> > > > > PKG_CONFIG_PATH. I also think we should remove CMAKE_CONFIG_PATH
> > > > > from the find_package call
> > 
> > in
> > 
> > > > > CMakeLists.txt. It is not a standard CMake variable and it would be
> > > > > better to use something like CMAKE_PREFIX_PATH (although not in
> > > > > CMakeLists.txt).
> > > > > 
> > > > > [1] Actually ufc_DIR, but I suggest we rename ufc-config.cmake to
> > > > > UFCConfig.cmake such that CMake automatically searches UFC_DIR.
> > > > > 
> > > > > Johannes
> > > > > 
> > > > > _______________________________________________
> > > > > Mailing list: https://launchpad.net/~dolfin
> > > > > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > > > > Unsubscribe : https://launchpad.net/~dolfin
> > > > > More help   : https://help.launchpad.net/ListHelp
> > > > 
> > > > _______________________________________________
> > > > Mailing list: https://launchpad.net/~dolfin
> > > > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > > > Unsubscribe : https://launchpad.net/~dolfin
> > > > More help   : https://help.launchpad.net/ListHelp