dolfin team mailing list archive

[Johan Hake <johan.hake@xxxxxxxxx>]

On Friday February 3 2012 13:58:21 Benjamin Kehlet wrote:
> 2012/2/3 Johan Hake <johan.hake@xxxxxxxxx>:
> > On Friday February 3 2012 13:40:27 Garth N. Wells wrote:
> >> On 3 February 2012 11:35, Anders Logg <logg@xxxxxxxxx> wrote:
> >> > On Fri, Feb 03, 2012 at 10:13:23AM +0100, Johan Hake wrote:
> >> >> On Friday February 3 2012 10:11:10 Garth N. Wells wrote:
> >> >> > On 3 February 2012 08:38, Garth N. Wells <gnw20@xxxxxxxxx> wrote:
> >> >> > > On 2 February 2012 19:48, Johan Hake <johan.hake@xxxxxxxxx> wrote:
> >> >> > >> I cannot compiled dolfin now. I am getting:
> >> >> > >> 
> >> >> > >>  In file included from
> >> >> > >> /home/hake/local/include/CGAL/Triangulation_data_structure_3.h:4
> >> >> > >> 3:0 , from /home/hake/local/include/CGAL/Triangulation_3.h:35,
> >> >> > >> from /home/hake/bzr/fenics/dolfin/work-
> >> >> > >> trunk/dolfin/generation/cgal_triangulate.h:30,
> >> >> > >>                 from /home/hake/bzr/fenics/dolfin/work-
> >> >> > >> trunk/dolfin/generation/CGALMeshBuilder.h:32,
> >> >> > >>                 from /home/hake/bzr/fenics/dolfin/work-
> >> >> > >> trunk/dolfin/generation/Triangulate.cpp:28:
> >> >> > >> /home/hake/local/include/CGAL/Triangulation_ds_cell_base_3.h: In
> >> >> > >> constructor
> >> >> > >> ‘CGAL::Triangulation_ds_cell_base_3<TDS>::Triangulation_ds_cell_
> >> >> > >> bas e_3( CGAL::Triangulation_ds_cell_base_3<TDS>::Vertex_handle,
> >> >> > >> CGAL::Triangulation_ds_cell_base_3<TDS>::Vertex_handle,
> >> >> > >> CGAL::Triangulation_ds_cell_base_3<TDS>::Vertex_handle,
> >> >> > >> CGAL::Triangulation_ds_cell_base_3<TDS>::Vertex_handle)’:
> >> >> > >> /home/hake/local/include/CGAL/Triangulation_ds_cell_base_3.h:50
> >> >> > >> :43: error: ISO C++ forbids compound-literals
> >> >> > >> 
> >> >> > >> I have last CGAL 3.9, g++ 4.5.2
> >> >> > > 
> >> >> > > I'll take a look. CGAL 3.8 works, and I can reproduce the error
> >> >> > > with CGAL 3.9.
> >> >> > 
> >> >> > I've just pushed a fix. CGAL 3.9 uses a g++-specific extension
> >> >> > which yields and error when using strict compiler flags. I've
> >> >> > added a CGAL flag to disable use of the g++ extension.
> >> >> 
> >> >> Cool!
> >> > 
> >> > It works fine here.
> >> > 
> >> > Are there any license issues regarding the CGAL mesh generation
> >> > library?
> >> 
> >> No more than we already have with the intersection code which uses
> >> some of the CGAL QPL'd components.
> >> 
> >> I'm not a lawyer and I can't find a definitive answer anywhere, but my
> >> reading of the licences is that it's fine, especially since we don't
> >> depend on CGAL. The CGAL license basically says that code built using
> >> CGAL must be made available under an open source license. We're
> >> complying with this, and if someone using DOLFIN is unwilling to do
> >> this then they shouldn't enable CGAL.
> > 
> > It actually looks like we need to explicitly ammend something to the GLP
> > license we use, to be able to use CGAL.
> > 
> > >From http://www.cgal.org/license.html:
> >  The General Public License (GPL) has a viral effect which makes it
> >  incompatible with the QPL. For more information, please refer to the
> >  paragraph about the QPL on the licenses web page of the FSF. It is
> > therefore not possible to build a program including GPL code and some
> > QPL parts of CGAL. In this case, if you are the copyright owner of the
> > GPL code, you can amend the license by adding an exception allowing the
> > use of CGAL with it (see again the FSF web page).
> > 
> > I couldn't find the refered pages on fsf site, as it only pointed to a
> > dead link.
> 
> This might be what you are looking for:
>   As a special exception, you have permission to link this program
>   with the FOO library and distribute executables, as long as you
>   follow the requirements of the GNU GPL in regard to all of the
>   software in the executable aside from FOO.
> 
> Link: http://www.gnu.org/licenses/license-list.html#QPL

Yes, this looks very much like it. Following the instruction on this page we 
should then add that snippet after our GPL snippet in all source files I 
think...

Johan

> Benjamin
> 
> > Johan
> > 
> >> Garth
> >> 
> >> > --
> >> > Anders
> >> > 
> >> >> Johan
> >> >> 
> >> >> > Garth
> >> >> > 
> >> >> > > Garth
> >> >> > > 
> >> >> > >> Johan
> >> >> > >> 
> >> >> > >> _______________________________________________
> >> >> > >> Mailing list: https://launchpad.net/~dolfin
> >> >> > >> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> >> >> > >> Unsubscribe : https://launchpad.net/~dolfin
> >> >> > >> More help   : https://help.launchpad.net/ListHelp
> >> >> 
> >> >> _______________________________________________
> >> >> Mailing list: https://launchpad.net/~dolfin
> >> >> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> >> >> Unsubscribe : https://launchpad.net/~dolfin
> >> >> More help   : https://help.launchpad.net/ListHelp
> >> 
> >> _______________________________________________
> >> Mailing list: https://launchpad.net/~dolfin
> >> Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> >> Unsubscribe : https://launchpad.net/~dolfin
> >> More help   : https://help.launchpad.net/ListHelp
> > 
> > _______________________________________________
> > Mailing list: https://launchpad.net/~dolfin
> > Post to     : dolfin@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~dolfin
> > More help   : https://help.launchpad.net/ListHelp