← Back to team overview

dolfin team mailing list archive

Re: Pushing removed revisions

 

On Mon, Dec 03, 2012 at 10:08:00AM +0100, Johan Hake wrote:
> In principle I do not have any objections. Also if you mess up your
> commands it is fairly simple to just branch a new lp:dolfin and merge
> from that, before it is pushed back.

The problem is that the thing I messed up was the push to
trunk. So there was no need or any opportunity to branch a new
lp:dolfin. The damage was already done.

> However, I see this mainly as a big short coming of bzr and/or buildbot.
> Comparing if one revision is newer than another one in a distributed
> version control system should be a solved problem...

It's a solved problem if we set that flag.

--
Anders


> Have you tried to fix this on the buildbot side Johannes?
>
> Johan
>
> On 12/03/2012 09:58 AM, Anders Logg wrote:
> > I want to bring up the "removed revisions" issue again...
> >
> > To prevent getting "removed revisions" changesets into trunk, it's
> > possible to set a simple configuration flag on the lp branch. There
> > was quite a bit of resistance to adding this flag last time we
> > discussed it, and the arguments in favor were perhaps not that strong
> > (mainly aesthetical).
> >
> > But now it seems there's actually a very good reason for adding that
> > flag. The buildbots are currently messed up because someone pushed the
> > wrong way... actually myself but I didn't do it to prove a point, I
> > just messed up my commands. As a result, the buildbots will not be
> > able to recognize changes for another 20 changesets or so and need to
> > be started manually.
> >
> > Are there any objections to adding that config flag to prevent this
> > from happening again in the future?
> >
>


Follow ups

References