dulwich-users team mailing list archive

[David Borowitz <dborowitz@xxxxxxxxxx>]

Hi Matthew,

Thanks for your work! We know that the command-line and working-directory
features of dulwich are still somewhat lacking, and patches are certainly
welcome. My only advice for coding these features would be to keep the
dulwich script itself as simple as possible, and implement features as
methods in the appropriate classes. (For example, checkout(dirname) would be
a method in the BaseRepo object rather than a function in bin/dulwich.)

Jelmer can probably answer this better when he gets back from vacation, but
AFAIK the primary development location is the git repo at
http://git.samba.org/?p=jelmer/dulwich.git. I've been trying to mail patches
to dulwich-users with git send-email. However, Jelmer likes bzr and is the
only person with commit access, so he may be able to suggest an easier way
to get your bzr changes into the mainline.

Dave

On Sat, Jul 10, 2010 at 15:17, Matthew Daniel <mdaniel@xxxxxxxxx> wrote:

> Hello,
>
> I have created a bzr branch in launchpad (my first experience with bzr
> and my first with launchpad) for the purpose of making `bin/dulwich`
> more user-friendly.
>
> It made me very happy that dulwich could clone git repos using only
> Python (since mingw-git and I have some disagreements sometimes).
> However, it was pretty irritating that it could only _clone_ them, and
> not `checkout` the files into the WC.
>
> So I fixed it in my branch. I also fiddled around by implementing some
> other Git commands, and updated the docstrings for the main library as
> I found parts lacking.
>
> My question is about the workflow. I was going to use that nifty
> looking button in launchpad "suggest for merge", but I figured it
> would be better to ask before trying out buttons that I didn't know
> [exactly] what they would do. :-)
>
> Is there a code review process? If so, may I request one, for the goal
> of having the code on lp:~mdaniel/dulwich/main land on the trunk?
>
>  Thanks kindly,
>  -- /v\atthew
>
> _______________________________________________
> Mailing list: https://launchpad.net/~dulwich-users
> Post to     : dulwich-users@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~dulwich-users
> More help   : https://help.launchpad.net/ListHelp
>