dulwich-users team mailing list archive
-
dulwich-users team
-
Mailing list archive
-
Message #00246
Fix parameter order for Tree.add
affects dulwich
status triaged
importance low
On Tue, 2010-10-19 at 10:07 -0700, David Borowitz wrote:
> On Sat, Oct 16, 2010 at 14:59, Jelmer Vernooij <jelmer@xxxxxxxxx>
> wrote:
> On Fri, 2010-10-08 at 12:51 -0700, David Borowitz wrote:
> > Another place with a completely different order:
> Tree.add(mode, name,
> > sha). I don't suppose that's one we can safely change, is
> it?
>
> I guess we could check the types of mode and name and reverse
> them (and
> print a DeprecationWarning) if they're wrong.
>
> It's not entirely nice but I think the cleanest way of fixing
> it.
>
>
> Yeah. I don't have a sense of whether this is a thing other Python
> projects do...
>
>
> I'm happy to make this change but it's not on my critical path at the
> moment.
Attachment:
signature.asc
Description: This is a digitally signed message part
References