← Back to team overview

duplicity-team team mailing list archive

[Bug 426282] Re: [PATCH] par2 creating support

 

I'm using this patch for a couple of days now. I've already made 2 modifications to the code.
2 more patches are attached, I've tested and they also work against the current 0.7-series branch.

The first patch avoids storing all the par2 files into the local cache.
On my installation, the --archive-dir directory was growing up beyond
the gigabyte limit since I applied the par2 patch, which was way too
much !

** Attachment added: "duplicity-dont-sync-par2-files-with-local-cache.diff"
   http://launchpadlibrarian.net/33081929/duplicity-dont-sync-par2-files-with-local-cache.diff

-- 
[PATCH] par2 creating support
https://bugs.launchpad.net/bugs/426282
You received this bug notification because you are a member of
duplicity-team, which is a bug assignee.

Status in duplicity - Bandwidth Efficient Encrypted Backup: In Progress

Bug description:
OK, this add support for creating par2 recovery files for every file that gets uploaded to the backend.

- can be enabled by passing --par2. If the backend already contains par2 files there is no need to pass the --par2 option.
- the par2 files are created just before the upload of the file so this will not break the asynchronous mode.
- all par2 files are preserved in the local cache and uploaded to the backend.


todo:
- add comments and logging
- add support for customizing the pa2 options currently 20% redundancy is used which might be an overkill or too little for someone
- don't use os.system and add error handling.
- add support for recovery.
  
Code review will be greatly appreciated. There are some very ugly hacks with temp files