← Back to team overview

duplicity-team team mailing list archive

[Bug 426282] Re: [PATCH] par2 creating support

 

This second patch skips the par2 files when building up the sets and
chains of backups, used for the collection-status command. Without it,
the par2 files were considered as being incomplete backups:

Also found 0 backup sets not part of any chain,
and 2 incomplete backup sets.
These may be deleted by running duplicity with the --cleanup option.

This is misleading because the cleanup command won't remove those files (of course!) and we'll still get the "incomplete backup sets" message on the next collection-status command.
After this patch is applied, a duplicity collection-status on the same backup profile says:

No orphaned or incomplete backup sets found.

Hopefully there's no side effect. Haven't noticed any for now, but it
may require more testing.

** Attachment added: "duplicity-skip-par2-files-for-status-command.diff"
   http://launchpadlibrarian.net/33086493/duplicity-skip-par2-files-for-status-command.diff

-- 
[PATCH] par2 creating support
https://bugs.launchpad.net/bugs/426282
You received this bug notification because you are a member of
duplicity-team, which is a bug assignee.

Status in duplicity - Bandwidth Efficient Encrypted Backup: In Progress

Bug description:
OK, this add support for creating par2 recovery files for every file that gets uploaded to the backend.

- can be enabled by passing --par2. If the backend already contains par2 files there is no need to pass the --par2 option.
- the par2 files are created just before the upload of the file so this will not break the asynchronous mode.
- all par2 files are preserved in the local cache and uploaded to the backend.


todo:
- add comments and logging
- add support for customizing the pa2 options currently 20% redundancy is used which might be an overkill or too little for someone
- don't use os.system and add error handling.
- add support for recovery.
  
Code review will be greatly appreciated. There are some very ugly hacks with temp files