← Back to team overview

duplicity-team team mailing list archive

Re: [Merge] lp:~mterry/duplicity/early-catch-498933 into lp:duplicity

 

On 23.08.2011 20:25, Kenneth Loafman wrote:
> The size info is the problem.  Each backend returns a list of filenames, but
> getting size info is problematic.  That's going to be a major piece of work
> to get that info.

I am no pythonist per se, but is there a possibility to add a list_extended to backends that would fetch these infos, if possible? So if a backend supports these, they are there in a list structure 
0=>{[name]=>,[size]=>,...},1=>{[name]=>,[size]=>,...},2=>.... 
if not (or if not implemented by now) only they are missing 
0=>{[name]=>},1=>{[name]=>},2=>....

The victim of zero sized files here http://lists.gnu.org/archive/html/duplicity-talk/2011-08/msg00013.html used the ftp backend, which actually could deliver this info.

> 
> Downloading the file is not a good idea.  Performance would take a serious
> hit, i.e. double the time for backups.  If we could get file size info, we
> would know that the sizes were correct, and that's what we need.

agreed, see my verify does this point
 
> My guess is that the zero length files are really the last file transmitted
> before a backup failed.  Getting file sizes would help in proving this.

exactly my point. ede


> 
> ...Ken
> 
> On Tue, Aug 23, 2011 at 1:02 PM, Michael Terry
> <michael.terry@xxxxxxxxxxxxx>wrote:
> 
>> That is a good and sensible idea, but the current backend.list architecture
>> isn't well suited for that, performance wise.
>>
>> (A) We can't ask for information about just one file, we have to list all
>> files each time
>> (B) We can't ask for size information.  We'd have to download the file
>> again.
>>
>> Both could be solved by after each upload, just downloading the file again
>> and comparing to the original to 'prove' the round trip worked.  That's a
>> decent idea, actually, just seems a lot less performant.
>>
>> I could whip that up, depending on interest.  Ken?
>> --
>>
>> https://code.launchpad.net/~mterry/duplicity/early-catch-498933/+merge/72607<https://code.launchpad.net/%7Emterry/duplicity/early-catch-498933/+merge/72607>
>> Your team duplicity-team is requested to review the proposed merge of
>> lp:~mterry/duplicity/early-catch-498933 into lp:duplicity.
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~duplicity-team
>> Post to     : duplicity-team@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~duplicity-team
>> More help   : https://help.launchpad.net/ListHelp
>>
> 

-- 
https://code.launchpad.net/~mterry/duplicity/early-catch-498933/+merge/72607
Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/early-catch-498933 into lp:duplicity.


References