duplicity-team team mailing list archive

[Kenneth Loafman <kenneth@xxxxxxxxxxx>]

Not really a good fix, just expedient.  The check should have been left as
is but changed to 'LFTPBackend' since that's now the default.

As to being useless, not sure.  It's a very basic check of
get_backend_object().  Would be confusing if that failed.



On Thu, Nov 13, 2014 at 9:23 AM, <edgar.soldin@xxxxxx> wrote:

> i don't like the fix. as we now have multiple ftp capable backends the
> proper check would be if
>  duplicity.backend.get_backend_object(url)
> returns a proper backend.
>
> by the looks of it the method already throws an exception in that case, so
> i'd argue the assertion needless.
>
> ..ede
>
> On 13.11.2014 15:53, Kenneth Loafman wrote:
> >
> > I just pushed a fix for the problem:
> >
> > Traceback (most recent call last):
> >   File
> "/home/ken/workspace/duplicity-src/testing/unit/test_backend_instance.py",
> line 237, in setUp
> >     self.assertEqual(self.backend.__class__.__name__, 'FTPBackend')
> > AssertionError: 'LFTPBackend' != 'FTPBackend'
>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~duplicity-team
> Post to     : duplicity-team@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~duplicity-team
> More help   : https://help.launchpad.net/ListHelp
>