duplicity-team team mailing list archive

[Michael Terry <mike@xxxxxxxxxxx>]

Michael Terry has proposed merging lp:~mterry/duplicity/pydrive-root into lp:duplicity.

Requested reviews:
  duplicity-team (duplicity-team)

For more details, see:
https://code.launchpad.net/~mterry/duplicity/pydrive-root/+merge/363587

Just a tiny fix to clean up the temporary file we create to find the root ID. It's a little surprising for the user if they wind up with this file called "i_am_in_root" that they don't know where it came from. Almost sounds like they were hacked.
-- 
Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/pydrive-root into lp:duplicity.

=== modified file 'duplicity/backends/pydrivebackend.py'
--- duplicity/backends/pydrivebackend.py	2018-11-29 19:00:15 +0000
+++ duplicity/backends/pydrivebackend.py	2019-02-24 15:13:04 +0000
@@ -94,6 +94,7 @@
             file_in_root = self.drive.CreateFile({u'title': u'i_am_in_root'})
             file_in_root.Upload()
             parent_folder_id = file_in_root[u'parents'][0][u'id']
+            file_in_root.Delete()
 
         # Fetch destination folder entry and create hierarchy if required.
         folder_names = string.split(parsed_url.path, u'/')