duplicity-team team mailing list archive

[Michael Terry <mike@xxxxxxxxxxx>]

Michael Terry has proposed merging lp:~mterry/duplicity/pydrive-root-0.7 into lp:duplicity/0.7-series.

Requested reviews:
  duplicity-team (duplicity-team)

For more details, see:
https://code.launchpad.net/~mterry/duplicity/pydrive-root-0.7/+merge/363588

Just a tiny fix to clean up the temporary file we create to find the root ID. It's a little surprising for the user if they wind up with this file called "i_am_in_root" that they don't know where it came from. Almost sounds like they were hacked.
-- 
Your team duplicity-team is requested to review the proposed merge of lp:~mterry/duplicity/pydrive-root-0.7 into lp:duplicity/0.7-series.

=== modified file 'duplicity/backends/pydrivebackend.py'
--- duplicity/backends/pydrivebackend.py	2017-11-01 12:41:49 +0000
+++ duplicity/backends/pydrivebackend.py	2019-02-24 15:13:08 +0000
@@ -92,6 +92,7 @@
             file_in_root = self.drive.CreateFile({'title': 'i_am_in_root'})
             file_in_root.Upload()
             parent_folder_id = file_in_root['parents'][0]['id']
+            file_in_root.Delete()
 
         # Fetch destination folder entry and create hierarchy if required.
         folder_names = string.split(parsed_url.path, '/')