dx-packages team mailing list archive

[Charles Kerr <charles.kerr@xxxxxxxxxxxxx>]

Public bug reported:

Reported by Popey @
http://popey.com/~alan/phablet/device-2014-03-20-123802.png

Part of the cause for this is fairly straightforward. The code that
generates the snap decision is shown at http://bazaar.launchpad.net
/~indicator-applet-developers/indicator-
datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.

The relevant bit is that the two actions are added to the notification
only if (mode == NOTIFY_MODE_SNAP):

> auto nn = notify_notification_new(title, body.c_str(), icon_name);
> if (mode == NOTIFY_MODE_SNAP)
> {
> ...
>        notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
>        notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
> ...
> }
> ...
> notify_notification_show(nn, &error);

Where the mode is chosen based on this:

http://bazaar.launchpad.net/~indicator-applet-developers/indicator-
datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205

i.e., if the notification server doesn't say that it supports actions,
we fall back to bubble notification instead.

I see a TODO item in indicator-datetime would be to add some debugging
information here so that we can report exactly what server caps we got
back from libnotify. In addition, since this is being reported at the
same time that davmor2 is reporting bug #1295237, I think it makes sense
to pull unity-notifications into this for more pairs of eyes.

** Affects: indicator-datetime (Ubuntu)
     Importance: Undecided
     Assignee: Charles Kerr (charlesk)
         Status: Triaged

** Affects: unity-notifications (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-datetime in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1295271

Title:
  On phone, alarms being shown without dismiss/show buttons

Status in “indicator-datetime” package in Ubuntu:
  Triaged
Status in “unity-notifications” package in Ubuntu:
  New

Bug description:
  Reported by Popey @
  http://popey.com/~alan/phablet/device-2014-03-20-123802.png

  Part of the cause for this is fairly straightforward. The code that
  generates the snap decision is shown at http://bazaar.launchpad.net
  /~indicator-applet-developers/indicator-
  datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L225.

  The relevant bit is that the two actions are added to the notification
  only if (mode == NOTIFY_MODE_SNAP):

  > auto nn = notify_notification_new(title, body.c_str(), icon_name);
  > if (mode == NOTIFY_MODE_SNAP)
  > {
  > ...
  >        notify_notification_add_action(nn, "show", _("Show"), on_snap_show, data, nullptr);
  >        notify_notification_add_action(nn, "dismiss", _("Dismiss"), on_snap_dismiss, data, nullptr);
  > ...
  > }
  > ...
  > notify_notification_show(nn, &error);

  Where the mode is chosen based on this:

  http://bazaar.launchpad.net/~indicator-applet-developers/indicator-
  datetime/trunk.14.04/view/head:/src/snap.cpp?start_revid=324#L205

  i.e., if the notification server doesn't say that it supports actions,
  we fall back to bubble notification instead.

  I see a TODO item in indicator-datetime would be to add some debugging
  information here so that we can report exactly what server caps we got
  back from libnotify. In addition, since this is being reported at the
  same time that davmor2 is reporting bug #1295237, I think it makes
  sense to pull unity-notifications into this for more pairs of eyes.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/indicator-datetime/+bug/1295271/+subscriptions