← Back to team overview

dx-packages team mailing list archive

[Bug 1430542] [NEW] Indicator doesn't use weighted average with different-sized batteries

 

Public bug reported:

The indicator implements the spec:

  https://wiki.ubuntu.com/Power#Handling_multiple_batteries

which states:

  "Their percentages should be averaged."

Apparently this was taken to mean the simple arithmetic mean, and not
the weighted average (by the capacity of each battery).

  http://bazaar.launchpad.net/~indicator-applet-developers/indicator-
power/trunk.15.04/view/head:/src/service.c#L1316

shows:

  const double percent = sum_percent / n_batteries;

This means that if one battery is twice as large as another, then after
that battery is discharged, 50% would be reported.  I'd expect 33%.

The spec needs to be updated to be less ambiguous about the intended
meaning of the word "average" and the code needs to be fixed.

** Affects: indicator-power (Ubuntu)
     Importance: Undecided
         Status: New

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-power in Ubuntu.
https://bugs.launchpad.net/bugs/1430542

Title:
  Indicator doesn't use weighted average with different-sized batteries

Status in indicator-power package in Ubuntu:
  New

Bug description:
  The indicator implements the spec:

    https://wiki.ubuntu.com/Power#Handling_multiple_batteries

  which states:

    "Their percentages should be averaged."

  Apparently this was taken to mean the simple arithmetic mean, and not
  the weighted average (by the capacity of each battery).

    http://bazaar.launchpad.net/~indicator-applet-developers/indicator-
  power/trunk.15.04/view/head:/src/service.c#L1316

  shows:

    const double percent = sum_percent / n_batteries;

  This means that if one battery is twice as large as another, then
  after that battery is discharged, 50% would be reported.  I'd expect
  33%.

  The spec needs to be updated to be less ambiguous about the intended
  meaning of the word "average" and the code needs to be fixed.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/indicator-power/+bug/1430542/+subscriptions


Follow ups

References