← Back to team overview

dx-packages team mailing list archive

[Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken

 

Hello Dmitry, or anyone else affected,

Accepted indicator-session into trusty-proposed. The package will build
now and be available at https://launchpad.net/ubuntu/+source/indicator-
session/12.10.5+14.04.20150404-0ubuntu1 in a few hours, and then in the
-proposed repository.

Please help us by testing this new package.  See
https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to
enable and use -proposed.  Your feedback will aid us getting this update
out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug,
mentioning the version of the package you tested, and change the tag
from verification-needed to verification-done. If it does not fix the
bug for you, please add a comment stating that, and change the tag to
verification-failed.  In either case, details of your testing will help
us make a better decision.

Further information regarding the verification process can be found at
https://wiki.ubuntu.com/QATeam/PerformingSRUVerification .  Thank you in
advance!

** Changed in: indicator-session (Ubuntu Trusty)
       Status: In Progress => Fix Committed

** Tags added: verification-needed

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-session in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1363630

Title:
  Since revision 446.1.3, Zenity backend is broken

Status in Ubuntu GNOME Flashback:
  Fix Released
Status in indicator-session package in Ubuntu:
  Fix Released
Status in indicator-session source package in Trusty:
  Fix Committed

Bug description:
  Currently the code in zenity_question() looks like:

  if (!g_spawn_check_exit_status (exit_status, &error))
        confirmed = TRUE;
  else
        confirmed = exit_status == 0;

  However !g_spawn_check_exit_status() call is mostly equivalent to
  "exit_status != 0". Thus, confirmed will be *always* set to TRUE, even
  if the user cancelled the dialog.

  I have prepared a branch to fix this.

  == Impact ==
  The Cancel buttons in shutdown/end session dialogs are not working, and do the same as "OK" buttons. This may lead to data loss due to unsaved documents/etc.

  == Test Case ==
  * Log in to GNOME Flashback session.
  * Select "Shutdown" from indicator-session menu.
  * In the popped up dialog select "Cancel".

  Expected result: the dialog will close, the machine won't shut down.

  == Development / Stable Fix ==
  Please see the attached branches.

  == Regression Potential ==
  The fix is part of 14.10 release and was confirmed to work fine. So no regression potential.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions


References