← Back to team overview

dx-packages team mailing list archive

[Bug 1363630] [NEW] Since revision 446.1.3, Zenity backend is broken

 

Public bug reported:

Currently the code in zenity_question() looks like:

if (!g_spawn_check_exit_status (exit_status, &error))
      confirmed = TRUE;
else
      confirmed = exit_status == 0;

However !g_spawn_check_exit_status() call is mostly equivalent to
"exit_status != 0". Thus, confirmed will be *always* set to TRUE, even
if the user cancelled the dialog.

I have prepared a branch to fix this.

** Affects: ubuntu-flashback
     Importance: High
         Status: New

** Affects: indicator-session (Ubuntu)
     Importance: High
     Assignee: Dmitry Shachnev (mitya57)
         Status: In Progress


** Tags: utopic

** Tags added: utopic

** Also affects: ubuntu-flashback
   Importance: Undecided
       Status: New

** Changed in: ubuntu-flashback
   Importance: Undecided => High

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-session in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1363630

Title:
  Since revision 446.1.3, Zenity backend is broken

Status in Ubuntu Flashback:
  New
Status in “indicator-session” package in Ubuntu:
  In Progress

Bug description:
  Currently the code in zenity_question() looks like:

  if (!g_spawn_check_exit_status (exit_status, &error))
        confirmed = TRUE;
  else
        confirmed = exit_status == 0;

  However !g_spawn_check_exit_status() call is mostly equivalent to
  "exit_status != 0". Thus, confirmed will be *always* set to TRUE, even
  if the user cancelled the dialog.

  I have prepared a branch to fix this.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-flashback/+bug/1363630/+subscriptions


Follow ups

References