← Back to team overview

dx-packages team mailing list archive

[Bug 1363630] Re: Since revision 446.1.3, Zenity backend is broken

 

@ Alberts, did you read my comment #6? An initial reboot is required
after upgrading 'indicator-session'. I got no "restart required"
notification but that may be because I was using the terminal, eg;

Step #1: Enable proposed

Step #2: run "apt-get update"

Step #3: run "apt-get install indicator-session"

Step #4: Disable proposed and run "apt-get update" again to prevent
unwanted updates from proposed.

Step #5 : Resume testing and you'll discover that an initial reboot is
required for the change to take effect. After that initial reboot all
restart, shutdown, logout, and cancel buttons work as they should.

The only reason I didn't give this a verification-done nod is because I
was unsure if "Restart required (restart_now_or_later)" needs to be
added to this update. As I said, it's also possible that if updated
using the update-manager such warning would be given .................
I'm not tech savvy enough to know how the "restart required"
notifications are handled when appropriate.

-- 
You received this bug notification because you are a member of DX
Packages, which is subscribed to indicator-session in Ubuntu.
Matching subscriptions: dx-packages
https://bugs.launchpad.net/bugs/1363630

Title:
  Since revision 446.1.3, Zenity backend is broken

Status in Ubuntu GNOME Flashback:
  Fix Released
Status in indicator-session package in Ubuntu:
  Fix Released
Status in indicator-session source package in Trusty:
  Fix Committed

Bug description:
  Currently the code in zenity_question() looks like:

  if (!g_spawn_check_exit_status (exit_status, &error))
        confirmed = TRUE;
  else
        confirmed = exit_status == 0;

  However !g_spawn_check_exit_status() call is mostly equivalent to
  "exit_status != 0". Thus, confirmed will be *always* set to TRUE, even
  if the user cancelled the dialog.

  I have prepared a branch to fix this.

  == Impact ==
  The Cancel buttons in shutdown/end session dialogs are not working, and do the same as "OK" buttons. This may lead to data loss due to unsaved documents/etc.

  == Test Case ==
  * Log in to GNOME Flashback session.
  * Select "Shutdown" from indicator-session menu.
  * In the popped up dialog select "Cancel".

  Expected result: the dialog will close, the machine won't shut down.

  == Development / Stable Fix ==
  Please see the attached branches.

  == Regression Potential ==
  The fix is part of 14.10 release and was confirmed to work fine. So no regression potential.

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu-gnome-flashback/+bug/1363630/+subscriptions


References