← Back to team overview

ecryptfs-devel team mailing list archive

Maybe a bug

 

Hi,
line 236 of fs/ecryptfs/messaging.c looks wrong :

====
        rc = ecryptfs_find_daemon_by_euid(&old_daemon, euid, user_ns);
        if (rc != 0) {
                printk(KERN_WARNING "Received request from user [%d] "
                       "to register daemon [0x%p]; unregistering daemon
"
                       "[0x%p]\n", euid, pid, old_daemon->pid);
                rc = ecryptfs_send_raw_message(ECRYPTFS_MSG_QUIT,
old_daemon);
====

Doesn't rc != 0 mean that it was _not_ found ?

changing it to (rc == 0) would make more sense to me




Follow ups