edubuntu-bugs team mailing list archive

[Zrin Ziborski <925165@xxxxxxxxxxxxxxxxxx>]

Public bug reported:

Package: ltsp-server
Version: 5.2.16-0ubuntu7
Maintainer: Stephane Graber <stgraber@xxxxxxxxxx>
Release: 11.10 (oneiric)

AFAIU, (/opt/ltsp/.../usr/share/) initramfs-tools/scripts/ltsp_nbd
should respect the "nbdserver" parameter -
the relevant part of the function mountroot() should be amended to
something like

    if [ -n "${nbdroot}" ]; then
        # <host>:<port>
        NBD_ROOT_SERVER=$( echo "${nbdroot}" | sed 's/:.*//')
        NBD_ROOT_PORT=$( echo "${nbdroot}" | sed 's/.*://')
    else
        if [ -n "${nbdserver}" ]; then
                NBD_ROOT_SERVER="${nbdserver}"
        else
                NBD_ROOT_SERVER="${ROOTSERVER}"
        fi
        if [ -n "$nbdname" ]; then
            NBD_ROOT_NAME=${nbdname}
        else
            NBD_ROOT_PORT=${nbdport:-"2000"}
        fi
    fi

The logic behind mountroot() and scripts/ltsp_nbd probably needs
more thorough review and fixing.

best regards,

** Affects: ltsp (Ubuntu)
     Importance: Undecided
         Status: New


** Tags: nbdserver

** Description changed:

  Package: ltsp-server
  Version: 5.2.16-0ubuntu7
  Maintainer: Stephane Graber <stgraber@xxxxxxxxxx>
  Release: 11.10 (oneiric)
  
  AFAIU, (/opt/ltsp/.../usr/share/) initramfs-tools/scripts/ltsp_nbd
  should respect the "nbdserver" parameter -
  the relevant part of the function mountroot() should be amended to
+ something like
  
- 
-     if [ -n "${nbdroot}" ]; then
-         # <host>:<port>
-         NBD_ROOT_SERVER=$( echo "${nbdroot}" | sed 's/:.*//')
-         NBD_ROOT_PORT=$( echo "${nbdroot}" | sed 's/.*://')
-     else
-         if [ -n "${nbdserver}" ]; then
-                 NBD_ROOT_SERVER="${nbdserver}"
-         else
-                 NBD_ROOT_SERVER="${ROOTSERVER}"
-         fi
-         if [ -n "$nbdname" ]; then
-             NBD_ROOT_NAME=${nbdname}
-         else
-             NBD_ROOT_PORT=${nbdport:-"2000"}
-         fi
-     fi
- 
+     if [ -n "${nbdroot}" ]; then
+         # <host>:<port>
+         NBD_ROOT_SERVER=$( echo "${nbdroot}" | sed 's/:.*//')
+         NBD_ROOT_PORT=$( echo "${nbdroot}" | sed 's/.*://')
+     else
+         if [ -n "${nbdserver}" ]; then
+                 NBD_ROOT_SERVER="${nbdserver}"
+         else
+                 NBD_ROOT_SERVER="${ROOTSERVER}"
+         fi
+         if [ -n "$nbdname" ]; then
+             NBD_ROOT_NAME=${nbdname}
+         else
+             NBD_ROOT_PORT=${nbdport:-"2000"}
+         fi
+     fi
  
  The logic behind mountroot() and scripts/ltsp_nbd probably needs
  more thorough review and fixing.
  
  best regards,

-- 
You received this bug notification because you are a member of Edubuntu
Bugsquad, which is subscribed to ltsp in Ubuntu.
https://bugs.launchpad.net/bugs/925165

Title:
  in ltsp, initramfs-tools/scripts/ltsp_nbd does not respect the
  parameter "nbdserver"

To manage notifications about this bug go to:
https://bugs.launchpad.net/ubuntu/+source/ltsp/+bug/925165/+subscriptions