elementary-dev-community team mailing list archive

["Andrea Basso" <voluntatefaber@xxxxxxxxx>]

I think pretty much the same as Cody.

On Fri, 07 Sep 2012 17:27:40 +0200, Cody Garver <codygarver@xxxxxxxxx>  
wrote:

> I think "Disapprove" should be for when you don't like the code as a  
> whole
> or its concept or idea. Or the change entirely.
>
> And "Needs Fixing" should be for when you don't like a particular part of
> the code but it is actually attempting to fix a bug or make a desired
> change.
>
> What does everyone else think?
>
> On Fri, Sep 7, 2012 at 10:24 AM, David Gomes <david@xxxxxxxxxxxxxxxx>  
> wrote:
>
> > I'm very strict about the Coding Style, and what should I mark a branch
> > that I disapprove of because of its coding style - "Disapprove" or  
> > "Needs
> > fixing"?
> >
> > We should all be using the same thing, hence the question, thanks!
> >
> > David (Munchor)
> >
> > --
> > Mailing list: https://launchpad.net/~elementary-dev-community
> > Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
> > Unsubscribe : https://launchpad.net/~elementary-dev-community
> > More help   : https://help.launchpad.net/ListHelp