elementary-dev-community team mailing list archive

[Cassidy James <c@xxxxxxxxxxx>]

Yeah, if it's a good idea but needs to be cleaned up, Needs Fixing is the
way to go.
On Sep 7, 2012 10:28 AM, "Cody Garver" <codygarver@xxxxxxxxx> wrote:

> I think "Disapprove" should be for when you don't like the code as a whole
> or its concept or idea. Or the change entirely.
>
> And "Needs Fixing" should be for when you don't like a particular part of
> the code but it is actually attempting to fix a bug or make a desired
> change.
>
> What does everyone else think?
>
> On Fri, Sep 7, 2012 at 10:24 AM, David Gomes <david@xxxxxxxxxxxxxxxx>wrote:
>
>> I'm very strict about the Coding Style, and what should I mark a branch
>> that I disapprove of because of its coding style - "Disapprove" or "Needs
>> fixing"?
>>
>> We should all be using the same thing, hence the question, thanks!
>>
>> David (Munchor)
>>
>> --
>> Mailing list: https://launchpad.net/~elementary-dev-community
>> Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~elementary-dev-community
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>
>
> --
> Cody Garver
>
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp
>
>