← Back to team overview

elementary-dev-community team mailing list archive

Re: pantheon-terminal cleanup


Ah so that's why you commented on my stack overflow question :) (python vte

That would be quite awesome since with each iteration the code has become
more "messy".

Drop by in the irc #elementary-dev and ping me if you need anything.

p.s. i might respond a little late, a few busy days ahead.

Akshay Shekher <voldyman>
On 7 May 2015 08:03, "Craig" <weberc2@xxxxxxxxx> wrote:

> Hi folks,
> I'm looking at pantheon-terminal's source code, and it seems like some of
> the communication paths are quite convoluted. I was wondering if it would
> be okay if I refactored it so that the various classes don't know so much
> about each other (they can communicate over signals and callbacks without
> having to know details about how they connect to each other--object graph
> assembly can be delegated to a different class). This tight integration
> between classes makes it difficult to reason about, which in turn makes
> changes difficult and drives up the risk of introducing bugs.
> In doing this refactoring, I would be able to add in automated tests
> (currently, the tight coupling of components makes testing nigh
> impossible). I want to run this by the maintainers first, because it will
> be a significant change and I want to know that there is a decent chance of
> my changes making it into trunk (I don't want to waste my time or yours!).
> Please advise.
> Thanks,
> Craig
> --
> Mailing list: https://launchpad.net/~elementary-dev-community
> Post to     : elementary-dev-community@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~elementary-dev-community
> More help   : https://help.launchpad.net/ListHelp