elementaryart team mailing list archive

[Victor Eduardo <victormartinez79@xxxxxxxxx>]

Review: Needs Fixing

Hi, it's to see this is finally implemented. I think that sending an icon along with the icon_pressed() signal is unnecessary here, since handling the event is up to the "client".

In my opinion, it should look like:

    [...]

    public signal void search_icon_pressed ();

    [...]

    private void on_icon_press (EntryIconPosition position) {
        
            if (position == EntryIconPosition.SECONDARY) {
                is_searching = false;
                text = "";
                set_icon_from_stock (position, null);
                is_searching = true;
            } else {
                search_icon_pressed ();
                
                if (!this.has_focus) {
                    is_searching = false;
                    hint ();
                }
            }
        }

-- 
https://code.launchpad.net/~mefrio-g/granite/searchbar-icon-press-blueprint/+merge/86604
Your team elementaryart (old) is subscribed to branch lp:granite.