elisa-developers team mailing list archive

[Peter <peter@xxxxxxxxxxxxxxxxxxxxx>]

Hi all,

Thanks to whomever sorted out my application to join
the Elisa mailing list. I've started going over my patches
and tweaks to Moovida 1.0.x for possible contribution
to Elisa 1.0.x instead.

I've had a look at the archives, but I don't see anything
outlining how the group plan to handle merge requests.
I have noticed some merge requests handled via lp
(launchpad) which seems to require the contributor
setup a branch for the code first.

How would you like to handle "trivial" code changes
like the one below (a two line change), where to me
a whole branch seems like a lot of overhead?

For reference, the Moovida Bundle Buggy link was:
https://www.moovida.com/quality/review/request/%3C320fb6e01001270359m24088500o5546db78c9f4077a%40mail.gmail.com%3E

Thanks,

Peter

---------- Forwarded message ----------
From: Peter <peter@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, Jan 27, 2010 at 12:59 PM
Subject: [MERGE] Reduce seek step from 60s to 20s
To: Moovida merges list <merges-list@xxxxxxxxxxx>


Hello all,

This is a trivial two line patch to reduce the forward and reverse
seek step (in both audio and video players) from one minute
(60s) to just 20s.

The motivation is that currently (without using the mouse to
click on the timeline) the Moovida controls only allow jumps of
one minute, and holding down the left/right keys just does
multiple jumps. There is no fine grained control.

This patch is intended as a low risk partial solution, by allowing
jumps of 20s. Perhaps even changing this to 10s might be
better still?  As a recall from testing earlier this week XBMC
uses 20s by default.

Maybe this jump time should be user configurable?

In the long term I have some more complicated ideas to
put forward, as outlined on the forum here:
http://www.moovida.com/forums/viewtopic.php?f=8&t=1696

The code change is trivial. The reviewer should test both
audio and video (including plugins).

Thanks,

Peter

=== modified file 'elisa-plugins/elisa/plugins/poblesec/player_video.py'
--- elisa-plugins/elisa/plugins/poblesec/player_video.py	2009-12-01 12:16:26 +0000
+++ elisa-plugins/elisa/plugins/poblesec/player_video.py	2010-01-27 11:41:29 +0000
@@ -499,8 +499,8 @@
         self.volume_max = 1.0
         self.volume_increment = 0.05
         self.volume_decrement = 0.15
-        self.seek_backward_seconds = 60
-        self.seek_forward_seconds = 60
+        self.seek_backward_seconds = 20
+        self.seek_forward_seconds = 20
         self.key_repeat_count_second = 0.150
         self._last_key_time = time.time()
         self.playlist = None