elisa-developers team mailing list archive

[Olivier Tilloy <olivier@xxxxxxxxxx>]

Hi Peter,

On 2010-05-14, Peter <peter@xxxxxxxxxxxxxxxxxxxxx> wrote:
> Hi all,
> 
> Thanks to whomever sorted out my application to join
> the Elisa mailing list. I've started going over my patches
> and tweaks to Moovida 1.0.x for possible contribution
> to Elisa 1.0.x instead.

Welcome back on board! I believe Florian accepted your application, but
you have to thank Michał for this ;)

I did the same with the merge requests I had pending, let's see if we
can fix at least the outstanding issues in elisa 1.0.

> I've had a look at the archives, but I don't see anything
> outlining how the group plan to handle merge requests.
> I have noticed some merge requests handled via lp
> (launchpad) which seems to require the contributor
> setup a branch for the code first.
> 
> How would you like to handle "trivial" code changes
> like the one below (a two line change), where to me
> a whole branch seems like a lot of overhead?

This is an issue that had been extensively discussed some time ago, and
the need for a Launchpad account and a branch seemed like a high barrier
to entry for occasional contributors who submit tiny patches.
I personally like Launchpad's code review and merge system, but I agree
that we need a simpler mechanism for one-liners.

What about using this mailing list with attached patches, and anyone on
the team can review, approve and merge them? This makes the process less
structured but also more accessible to first-time contributors.

> For reference, the Moovida Bundle Buggy link was:
> https://www.moovida.com/quality/review/request/%3C320fb6e01001270359m24088500o5546db78c9f4077a%40mail.gmail.com%3E

Right now I need some time away from the keyboard to recover from an
intense week at UDS, but I'll have a look at your patch next week for sure.

> Thanks,
> 
> Peter

Cheers,

Olivier


> ---------- Forwarded message ----------
> From: Peter <peter@xxxxxxxxxxxxxxxxxxxxx>
> Date: Wed, Jan 27, 2010 at 12:59 PM
> Subject: [MERGE] Reduce seek step from 60s to 20s
> To: Moovida merges list <merges-list@xxxxxxxxxxx>
> 
> 
> Hello all,
> 
> This is a trivial two line patch to reduce the forward and reverse
> seek step (in both audio and video players) from one minute
> (60s) to just 20s.
> 
> The motivation is that currently (without using the mouse to
> click on the timeline) the Moovida controls only allow jumps of
> one minute, and holding down the left/right keys just does
> multiple jumps. There is no fine grained control.
> 
> This patch is intended as a low risk partial solution, by allowing
> jumps of 20s. Perhaps even changing this to 10s might be
> better still?  As a recall from testing earlier this week XBMC
> uses 20s by default.
> 
> Maybe this jump time should be user configurable?
> 
> In the long term I have some more complicated ideas to
> put forward, as outlined on the forum here:
> http://www.moovida.com/forums/viewtopic.php?f=8&t=1696
> 
> The code change is trivial. The reviewer should test both
> audio and video (including plugins).
> 
> Thanks,
> 
> Peter