elisa-developers team mailing list archive

[Olivier Tilloy <olivier@xxxxxxxxxx>]

On 2010-05-17, Paul van Tilburg <paul@xxxxxxxx> wrote:
> Hi!
> 
> On Mon, May 17, 2010 at 09:12:48AM +0200, Olivier Tilloy wrote:
>> It is indeed trivial, I did some quick functional tests and it behaves
>> as expected, and I think it is an acceptable temporary solution until a
>> true fine-grained seeking control is implemented. I will therefore merge
>> it, unless someone has a strong feeling against this change (I'll give
>> it a couple of days).
> 
> I have changed the same two values recently too.  I, however, matched
> totem's setup which is 10/30s.  Asymmetric?  Well yes, rewinding and
> forward winding are two different things.  Rewinding is to see something
> again you just missed, forward winding is to get to some position and
> that better not be too slow.  Maybe the latter is irrelevant if there
> are bookmarks.  But hey, it seems to be a personal preference anyway.
> 
> Kind regards,
> Paul

The reasoning is sensible. We already have the same kind of asymmetric
behaviour for the volume control.
There is potentially one perfect configuration for every single user, so
this definitely calls for values stored in the configuration file, with
sensible defaults. If anyone volunteers to write a patch for this, I'll
gladly participate in testing and reviewing it.
However I think Peter's patch is already a step forward, I'd still like
to merge it, whether it is with 20s/20s or with 10s/30s. Let's see if we
can come to an agreement.

Cheers,

Olivier