← Back to team overview

enterprise-support team mailing list archive

[Bug 1289754] [NEW] table_id is defined differently in sql/table.h vs sql/log_event.h

 

Public bug reported:

Description:
Binary log structure assumes that table_id in the event can be ulong, while the value is then assigned to table_id filed in TABLE structure that is defined as uint. This can cause overflow and problems during replication (events are not applied to correct table).

See https://bugs.launchpad.net/percona-server/+bug/1070255 for more
details on when overflow can happen and real impact for replication.

How to repeat:
Just do code review.

[openxs@chief mysql-5.6]$ grep -n 'table_id;' sql/table.h
1569:  uint          table_id; /* table id (from binlog) for opened table */
[openxs@chief mysql-5.6]$ grep -n 'table_id;' sql/log_event.h
3794:  ulong get_table_id() const        { return m_table_id; }
3859:  ulong          m_table_id;
3983:  ulong get_table_id() const        { return m_table_id; }
4078:  ulong       m_table_id;  /* Table ID */

See http://bugs.mysql.com/bug.php?id=67352 for details.

We need back port the fix to PS 5.5

** Affects: mysql-server
     Importance: Unknown
         Status: Unknown

** Affects: percona-server
     Importance: Undecided
         Status: Invalid

** Affects: percona-server/5.1
     Importance: Undecided
         Status: Won't Fix

** Affects: percona-server/5.5
     Importance: Undecided
     Assignee: Sergei Glushchenko (sergei.glushchenko)
         Status: In Progress

** Affects: percona-server/5.6
     Importance: Undecided
         Status: Invalid

** Also affects: percona-server/5.5
   Importance: Undecided
       Status: New

** Also affects: percona-server/5.1
   Importance: Undecided
       Status: New

** Also affects: percona-server/5.6
   Importance: Undecided
       Status: New

** Changed in: percona-server/5.1
       Status: New => Won't Fix

** Changed in: percona-server/5.5
       Status: New => In Progress

** Changed in: percona-server/5.6
       Status: New => Invalid

** Changed in: percona-server/5.5
     Assignee: (unassigned) => Sergei Glushchenko (sergei.glushchenko)

** Bug watch added: MySQL Bug System #67352
   http://bugs.mysql.com/bug.php?id=67352

** Also affects: mysql-server via
   http://bugs.mysql.com/bug.php?id=67352
   Importance: Unknown
       Status: Unknown

-- 
You received this bug notification because you are a member of Ubuntu
Server/Client Support Team, which is subscribed to MySQL.
Matching subscriptions: Ubuntu Server/Client Support Team
https://bugs.launchpad.net/bugs/1289754

Title:
  table_id is defined differently in sql/table.h vs sql/log_event.h

To manage notifications about this bug go to:
https://bugs.launchpad.net/mysql-server/+bug/1289754/+subscriptions


Follow ups

References