ffc team mailing list archive

[Anders Logg <logg@xxxxxxxxx>]

On Tue, Feb 24, 2009 at 03:37:31PM +0100, Kristian Oelgaard wrote:
> Quoting FFC <ffc@xxxxxxxxxx>:
> 
> > One or more new changesets pushed to the primary ffc repository.
> > A short summary of the last three changesets is included below.
> > 
> > changeset:   1328:83a16cff359ac9faf01d3af927e8d88a6005663e
> > tag:         tip
> > user:        "Kristian Oelgaard <k.b.oelgaard@xxxxxxxxxx>"
> > date:        Tue Feb 24 15:33:18 2009 +0100
> > files:       ffc/common/constants.py ffc/jit/jit.py ffc/jit/jitobject.py
> > test/verify_tensors/test.py
> > description:
> > Added option 'compiler' to FFC_OPTIONS, default is ffc. The JIT compiler uses
> > this to determine if the standard FFC compiler or the UFL compiler should be
> > used.
> 
> I ran all tests in DOLFIN and nothing seems to be broken. I fixed this by
> calling jit_object.signature() (to generate jit_object.form_data) BEFORE
> checking cache. If this is somehow unsafe, we need to come up with a different
> approach. I just think that it will introduce a small overhead?
> 
> Kristian

This was the problem I ran into when trying to fix the bug in jit.py
before release. I couldn't figure out how to solve it without doing as
you say, namely to generate the signature before checking the cache.

But this should be avoided. Computing the signature may actually take
some time. There are two levels of cache (although I don't know the
details of this now that it has moved into Instant): one in-memory
cache and one disk cache. The in-memory cache does not require the
signature, it just looks at the id() of the form which is faster
than computing and comparing signatures.

Why is this change needed for compilation of UFL forms?

-- 
Anders


> > 
> > changeset:   1327:4290605594500e5fbe61f7c57b0be4bf1c7f171b
> > user:        "Kristian Oelgaard <k.b.oelgaard@xxxxxxxxxx>"
> > date:        Tue Feb 24 11:30:14 2009 +0100
> > files:       ffc/compiler/codegeneration/quadrature/__init__.py
> > ffc/compiler/codegeneration/quadrature/uflquadraturegenerator.py
> > ffc/compiler/codegeneration/quadrature/uflquadraturegenerator_utils.py
> > ffc/compiler/representation/quadrature/uflquadraturerepresentation.py
> > ffc/compiler/uflcompiler.py
> > description:
> > UFL quadrature representation seems to work for quite a few forms (cell
> > integrals). Needs testing.
> > 
> > 
> > changeset:   1326:4929bd79f67f32b1b9abf9dbfd96c122d01d67f0
> > user:        Anders Logg <logg@xxxxxxxxx>
> > date:        Fri Feb 20 10:26:30 2009 +0100
> > files:       ffc/compiler/uflcompiler.py
> > description:
> > Testing monomial extraction in uflcompiler.py
> > 
> > ----------------------------------------------------------------------
> > For more details, visit http://www.fenics.org/hg/ffc
> > _______________________________________________
> > FFC-dev mailing list
> > FFC-dev@xxxxxxxxxx
> > http://www.fenics.org/mailman/listinfo/ffc-dev
> > 
> 
> 
> _______________________________________________
> FFC-dev mailing list
> FFC-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/ffc-dev

Attachment: signature.asc
Description: Digital signature