ffc team mailing list archive

["Garth N. Wells" <gnw20@xxxxxxxxx>]

Anders Logg wrote:
> On Sat, Mar 14, 2009 at 01:02:37AM +0000, Garth N. Wells wrote:
> > Anders Logg wrote:
> > > On Fri, Mar 13, 2009 at 06:30:33PM +0000, Garth N. Wells wrote:
> > > > There seem to have been a number of regressions lately. Compiling 
> > > > PoissonDG.ufl now gives the error
> > > >
> > > >    *** 'exterior_facet_integrals'
> > > This should be fixed now.
> > >
> > > > Is this issue also related to uflufcformat.py -> dolfinformat.py?
> > > Those to are unrelated.
> > There is some relationship between these files and some errors because 
> > Kristian made fixes in uflufcformat.py which worked, and after some 
> > commits it seems that dolfinformat.py is being used instead of 
> > uflufcformat.py
> >
> > Garth
>
> I made quite a few changes (simplifications and restructuring) to the
> new code generation which broke things, in particular for facet
> integrals, but it seems strange that dolfinformat.py should be used.
> As far as I can tell it's only being used for compilation of .form
> files, not .ufl files.

Kristian made some fixes for .form files in uflufcformat.py

  http://www.fenics.org/hg/ffc?cs=fe24d7b3b90a
  http://www.fenics.org/hg/ffc?cs=aca7d0ea2e24
  http://www.fenics.org/hg/ffc?cs=e2616554bb1f

which were then undone at some point. I mimiced the changes in 
dolfinformat.py which fixed one issue. Should

   def _generate_function_space(self, element, classname, element_map):

not be in uflufcformat.py? It's confusing that uflufcformat.py has code 
for writing DOLFIN FunctionSpaces, but other DOLFIN-specific code is in 
 dolfinformat.py.

Garth


> ------------------------------------------------------------------------
>
> _______________________________________________
> FFC-dev mailing list
> FFC-dev@xxxxxxxxxx
> http://www.fenics.org/mailman/listinfo/ffc-dev