ffc team mailing list archive

[Kristian Oelgaard <k.b.oelgaard@xxxxxxxxx>]

2010/1/13 Marie Rognes <meg@xxxxxxxxx>:
> Johan Hake wrote:
>>
>> On Wednesday 13 January 2010 12:26:25 Marie Rognes wrote:
>>
>>>
>>> Anders Logg wrote:
>>>
>>>>
>>>> On Wed, Jan 13, 2010 at 08:27:33PM +0100, Marie Rognes wrote:
>>>>
>>>>>
>>>>> Anders Logg wrote:
>>>>>
>>>>>>
>>>>>> On Wed, Jan 13, 2010 at 06:39:56PM +0100, Marie Rognes wrote:
>>>>>>
>>>>>>>
>>>>>>> noreply@xxxxxxxxxxxxx wrote:
>>>>>>>
>>>>>>>>
>>>>>>>> ------------------------------------------------------------
>>>>>>>> revno: 1443
>>>>>>>> committer: Anders Logg <logg@xxxxxxxxx>
>>>>>>>> branch nick: ffc-dev
>>>>>>>> timestamp: Wed 2010-01-13 17:00:13 +0100
>>>>>>>> message:
>>>>>>>> Remove \n in formats
>>>>>>>> modified:
>>>>>>>> ffc/cpp.py
>>>>>>>>
>>>>>>>
>>>>>>> I like the \n in formats. Makes more sense to me to have a line break
>>>>>>> after for instance "each assignment" than explicitly stating breaks
>>>>>>> in the code generation functions.
>>>>>>>
>>>>>>
>>>>>> I agree, but it becomes problematic in some cases. For example when we
>>>>>> insert things into the UFC format strings in the formatting stage:
>>>>>>
>>>>>>  /// Return the dimension of the finite element function space
>>>>>>  virtual unsigned int space_dimension() const
>>>>>>  {
>>>>>> %(space_dimension)s
>>>>>>  }
>>>>>>
>>>>>> Then we get things like
>>>>>>
>>>>>>  virtual unsigned int space_dimension() const
>>>>>>  {
>>>>>>   return 3;
>>>>>>
>>>>>>  }
>>>>>>
>>>>>
>>>>> Remove the "\n" in the format["return", "comment"] then ... and keep
>>>>> "iadd" and "assign" then?
>>>>>
>>
>> Sorry for bumping into the discussion with a potentially irrelevant
>> comment.
>>
>> Have you considered collecting code snippets in a list by
>>
>>  code_snippets.append(code_snippet)
>>
>> and then last you do a
>>
>>  code = "\n".join(code_snippets)
>>
>> This might also be faster (if this snippeting is ever going to be a bottle
>> neck?),
>
> On a related subject, do we have some fancy timing functionality to time the
> different
> compiler stages and different functions? (In the spirit of: time first,
> optimize afterwards ;) )

Definitely, but in my experience the time spent generating the code
for tabulate_tensor is "much "*7 larger than anything else in FFC.

Kristian

> --
> Marie
>
>> as string is immutable in Python which means that
>>  code_snippet += some_code
>>
>> always creates a new string.
>>
>>
>> Johan
>>
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~ffc
> Post to     : ffc@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~ffc
> More help   : https://help.launchpad.net/ListHelp
>