← Back to team overview

fuel-dev team mailing list archive

Re: Coding guidelines and OpenStack Infra

 

Thank you, Ruslan.
We still don't have dedicated DevOps engineer, but I hope we will get
someone to help with this :)


On Tue, Dec 17, 2013 at 7:09 PM, Ruslan Kamaldinov <rkamaldinov@xxxxxxxxxxxx
> wrote:

> It should be just a couple of lines in yaml.
>
>
> There are also jobs for Puppet lint and syntax checks.
>
> Here you can see definition of such job:
>
> https://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/jenkins_job_builder/config/projects.yaml#n1331
>
> Here you can find directive for zuul to run these jobs:
>
> https://git.openstack.org/cgit/openstack-infra/config/tree/modules/openstack_project/files/zuul/layout.yaml#n3139
>
>
> You can ping me if you'll need help with infra.
>
> Thanks,
> Ruslan
>
>
> On Tue, Dec 17, 2013 at 6:19 PM, Mike Scherbakov <mscherbakov@xxxxxxxxxxxx
> > wrote:
>
>> Ivan,
>> looks like great idea. Really, why to invent if we can reuse?
>>
>> Is it something simple to configure? (I believe it should be.. just YAML?)
>>
>>
>> On Tue, Dec 17, 2013 at 2:44 AM, Ivan Kolodyazhny <
>> ikolodyazhny@xxxxxxxxxxxx> wrote:
>>
>>> Andrey,
>>> yes, we have similar tests for it.
>>>
>>> But I propose to don't create own task/script/etc for pylint/pep checks.
>>> It would be great to use OpenStack infra for such tasks. It has all
>>> necessary tasks now: checks for pep8, pylint and development docs build for
>>> every review request for every python project. We just need to configure it
>>> and use.
>>>
>>> Let's use already created OpenStack infrastructure to be closer to
>>> community!
>>>
>>>
>>> On Thu, Dec 12, 2013 at 7:33 AM, Andrey Danin <adanin@xxxxxxxxxxxx>wrote:
>>>
>>>> I forgot to say the job it triggered by gerrit for every pull request.
>>>>
>>>>
>>>> Sent from my HTC
>>>>
>>>> ----- Reply message -----
>>>> From: "Andrey Danin" <adanin@xxxxxxxxxxxx>
>>>> To: "Ivan Kolodyazhny" <ikolodyazhny@xxxxxxxxxxxx>, "fuel-dev" <
>>>> fuel-dev@xxxxxxxxxxxxxxxxxxx>
>>>> Subject: Re: [Fuel-dev] Coding guidelines and OpenStack Infra
>>>> Date: Thu, Dec 12, 2013 09:31
>>>>
>>>>
>>>> We have a job on  fuel-jenkins.mirantis.com which runs flake8 and
>>>> jslint tests and all results are accessible via Internet. Is it not enough?
>>>>
>>>> Sent from my HTC----- Reply message -----
>>>>
>>>> From: "Ivan Kolodyazhny" <ikolodyazhny@xxxxxxxxxxxx>
>>>> To: "fuel-dev" <fuel-dev@xxxxxxxxxxxxxxxxxxx>
>>>> Subject: [Fuel-dev] Coding guidelines and OpenStack Infra
>>>> Date: Wed, Dec 11, 2013 13:59
>>>>
>>>> Hi Fuel developers!
>>>>
>>>> As you know, OpenStack has own coding guidelines
>>>> http://docs.openstack.org/developer/hacking/ and our projects are
>>>> following
>>>> them. But we have no good enough pep8 and pylint checks for every review
>>>> request.
>>>>
>>>> I propose use OpenStack Jenkins to run pep8 and pylint checks using
>>>> OpenStack scripts and settings for them like it works for nova (
>>>> https://jenkins.openstack.org/view/All/job/gate-nova-pep8/,
>>>> https://jenkins.openstack.org/view/All/job/gate-nova-pylint/) and other
>>>> projects.
>>>>
>>>> --
>>>> Regards,
>>>> Ivan "e0ne" Kolodyazhny,
>>>> Software Engineer, Mirantis, Inc.
>>>>
>>>
>>>
>>>
>>> --
>>> Regards,
>>> Ivan Kolodyazhny,
>>> Software Engineer, Mirantis, Inc.
>>>
>>> --
>>> Mailing list: https://launchpad.net/~fuel-dev
>>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>>> Unsubscribe : https://launchpad.net/~fuel-dev
>>> More help   : https://help.launchpad.net/ListHelp
>>>
>>>
>>
>>
>> --
>> Mike Scherbakov
>> #mihgen
>>
>> --
>> Mailing list: https://launchpad.net/~fuel-dev
>> Post to     : fuel-dev@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~fuel-dev
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>


-- 
Mike Scherbakov
#mihgen

Follow ups

References