← Back to team overview

gnome-terminator team mailing list archive

Re: Regarding Terminator modifications

 

Hi,

I want to update you that eventually things didn't turn out the expected
way and I will currently not work on the proposed ideas.
I made a commit with the work I did, I am uncertain this could be of use
but perhaps it might.
Although I could come back and work on some useful update of my own
sometime :-)

Thank you for your time,
Ariel



On Wed, May 14, 2014 at 7:31 PM, Stephen Boddy <
stephen.j.boddy@xxxxxxxxxxxxxx> wrote:

> Hi,
>
> Some responses inline below.
> --
> Regards
> Steve
>
> On 14 May 2014 14:43, Ariel Zelivanski <ariel.zelivans@xxxxxxxxx> wrote:
>
>> Hello,
>>
>> Thank you for the response Stephen! :-)
>> I got quite confused myself with the lists because I thought I will not
>> be able to send to gnome-terminator@xxxxxxxxxxxxxxxxxxx. I'll try to
>> have the discussion here if everything works correctly.
>>
>> I'll start with saying I am planning to work on each commit on a
>> different branch, so you can choose which to merge if at all.
>> Now, regarding the changes:
>>
>> 1. I know it works fine without any button. But I've been requested to
>> add a save button so if changes are made and not saved, they will be
>> discarded. When I am done with it you will get it, and you can decide what
>> to do with it.
>>
>
> So a suggestion: either a) a checkbox to toggle old/new behaviour that
> preferably defaults to the old behaviour, or b)  a cancel button as well,
> and track when changes are made. Then, if someone tries to close a window
> with the window close button when there are changes, prompt the user.
> Muscle-memory is a major factor for many, and forgetting to click that
> Apply button and having changes silently dumped would become annoying.
>
> One other note: I was wrong before; some settings are immediate, not just
> changed on closing. Case in point: some global settings are immediate
> (title bar colors, window geometry hints, for example) but others are not.
> Like I said I haven't looked at this code too closely so far, but it seems
> like it could do with some TLC in general.
>
>
>> 2. The idea is to remember the *command* used, open a terminal tab as
>> defined by the user, and in it run the command. I am still not sure how to
>> approach that to be honest but I'll have a better understanding once I see
>> how the code works.
>>
>
> OK. I still don't have any immediate suggestions for you on how this could
> be done.
>
>
>>  3. The user will define only *command* by configuration to run. For
>> example, "ls" - and when later "ls" is clicked it will run in the selected
>> terminal, without having to type the command.
>>
>
> Are you aware of the plugins? There is a "CustomCommandsMenu" plugin that
> does what you want, apart from the fact that the items are in the
> right-click context menu. It might not be enabled for you by default. I'd
> recommend extending that if you are looking to have, for example, a
> permanent floating window of commands.
>
>
>> 4. Perhaps I misunderstood the task myself and caused the confusion. I'll
>> mail you once I know what I plan to do.
>>
>
> Cool!
>
>
>>
>> I appreciate your helpfulness.
>> Thank you,
>> Ariel
>>
>>
>> On Wed, May 14, 2014 at 2:30 PM, Stephen Boddy <
>> stephen.j.boddy@xxxxxxxxxxxxxx> wrote:
>>
>>> Damn! I got confused and thought you sent to the dev list (
>>> gnome-terminator@xxxxxxxxxxxxxxxxxxx)<gnome-terminator@xxxxxxxxxxxxxxxxxxx>and you actually sent to the user list (
>>> terminator-users@xxxxxxxxxxxxxxxxxxx) Either one is fine.
>>>
>>>
>>> On 14 May 2014 13:25, Stephen Boddy <stephen.j.boddy@xxxxxxxxxxxxxx>wrote:
>>>
>>>> Hi Ariel,
>>>>
>>>> Perhaps counter-intuitively, the original list you sent your message to
>>>> is the correct one for discussing development issues. I've already
>>>> responded to it there, so let's keep that discussion there.
>>>> --
>>>> Regards
>>>> Steve
>>>>
>>>>
>>>> On 14 May 2014 12:03, Ariel Zelivansky <ariel.zelivans@xxxxxxxxx>wrote:
>>>>
>>>>> Hello,
>>>>>
>>>>> First of all, thank you for the informative rejection Stephen. I am not
>>>>> used to working with launchpad, but I think I now more or less
>>>>> understand what I need to do.
>>>>>
>>>>> I've sent a message to terminator-users group, and I believe what I
>>>>> actually intended was to send the message here so it can be viewed by
>>>>> upstream developers. The message is this: https://lists.launchpad.net
>>>>> /terminator-users/msg00021.html
>>>>>
>>>>> To make this shorter, the purpose of the message is to ask which of the
>>>>> following modifications are welcome to be merged by you:
>>>>>
>>>>> 1. Adding a save button in Preferences - Layout. Currently changes are
>>>>> saved when the window is closed.
>>>>> 2. When adding a layout, Terminator will automatically extract the last
>>>>> used commands from the terminals and add to Custom command.
>>>>> 3. Adding an option in preferences to add menu of frequently used
>>>>> commands
>>>>> (as customised by the user) which will appear on the top of the window.
>>>>> 4. Add the option to, via configuration, control each terminal's
>>>>> location
>>>>> using absolute values (like top, left...) for a layout.
>>>>>
>>>>> Thank you for your time.
>>>>>
>>>>> Regards,
>>>>> Ariel
>>>>> --
>>>>> This message was sent from Launchpad by
>>>>> Ariel Zelivansky (https://launchpad.net/~ariel-zelivans)
>>>>> using the "Contact this team's admins" link on the Terminator team page
>>>>> (https://launchpad.net/~gnome-terminator).
>>>>> For more information see
>>>>> https://help.launchpad.net/YourAccount/ContactingPeople
>>>>>
>>>>
>>>>
>>>
>>
>>
>> --
>> *Ariel Zelivansky *— 0503990401
>>
>> _______________________________________________
>> Mailing list: https://launchpad.net/~gnome-terminator
>> Post to     : gnome-terminator@xxxxxxxxxxxxxxxxxxx
>> Unsubscribe : https://launchpad.net/~gnome-terminator
>> More help   : https://help.launchpad.net/ListHelp
>>
>>
>


-- 
*Ariel Zelivansky *— 0503990401

References