gnome-zeitgeist-users team mailing list archive

[Tin Tvrtković <tinchester@xxxxxxxxx>]

Hello guys,

I've made some tweaks to the "today button", like I suggested, and
proposed a branch for review.

I've noticed GAJ is using a gtk.DrawingArea for the forward and backward
buttons. I believe a comparable effect might be achieved by using normal
gtk.Buttons with RELIEF_NONE and focus_on_click == False. In fact, I
think using buttons for buttons is a good idea overall, for several
reasons (like clarity of code, elegance of implementation, UI
consistency, etc). The buttons would look the same at rest, but maybe a
little differently when hovered and being pushed; however, it would
allow GAJ to shed some basically redundant code (like hooking the hover
signal in the forward button, to light up the today button) and would
allow, for instance, the today button to be focused by keyboard (not
happening right now, since it's a part of the forward button).

To summarize: if I switched the forward and backward button
implementations to gtk.Buttons, would you guys be willing to try out the
change?

Cheers,
Tin