← Back to team overview

gtg-contributors team mailing list archive

Re: Refactorisation progress : an indicible truth?

 

Le vendredi 26 février 2010 à 00:47 +0100, Bertrand Rousseau a écrit :

> I suggest you mark the problematic methods with a special comment,
> like #FIXME or #REFACTOR. I saw you already did this on some, it's a
> good idea to continue.

Yep, I did that.

> > Each time I'm solving something, I discover something else, it makes
> > progress really slow :-(
> 
> If you want some help, we could provide it, but you need to describe
> what precise problems must be solved, otherwise it's hard to jump in.

Hm, I understand that this is not easy. Right now, things are starting
to work (well, tasks and tags are displayed) and 0.2.2 will be released.

It's maybe a good time to jump in to understand a bit more the new code
base. (I plan to document that someday). A good start might be to read
the new requester and the comment at the start of FilteredTree.

Don't hesitate to ask me any question you might have when you don't
understand something. If you plan to work on a bug or a feature, just
ask me what you want to do and I will explain you if it fits in the
refactorisation and what should be done.

One issue I have currently (and I don't plan to work on it soon) is that
the "All tags" tag is displayed twice, I've no idea why. I also
discovered that drag-n-drop is broken in the TagTreeView. This is very
surprising as I don't remember touching it. 

There's also 39 FIXME and 28 TODO in the source code. Might be useful to
have a look.

If any of your work is touching the browser.py file, please get in touch
with me before doing anything, as long as it's not merged.


All in all, I'm seeing a lot of bad stuffs that are killing a kitten
but, in the end, I really consider that the roots are really well done.
There are a lot of stuffs that work automatically, and, that are even
sometimes elegant. Considering we are one year old only, that we
accepted many many patches from everywhere, this is a great achievement
and I'm very proud to be part of it.


Lionel





Follow ups

References