gtg-contributors team mailing list archive

[Bertrand Rousseau <bertrand.rousseau@xxxxxxxxx>]

On Fri, Feb 26, 2010 at 12:47 PM, Lionel Dricot <ploum@xxxxxxxxx> wrote:
> Le vendredi 26 février 2010 à 12:32 +0100, Bertrand Rousseau a écrit :
>
>> > I'm not really sure because all tags seems to be well in the TagStore.
>> > Printing it shows all tags but the treeview doesn't display all.  Maybe
>> > they are in the tagstore without sending a signal. Then, it's up to the
>> > tagstore to send the signal every time a tag is added.
>>
>> You're right. I'm starting to get a grip on this issue. Btw, I saw you
>> move the the pseudo tags code to the TagStore. I'm not sure it's the
>> best solution since they actually tag-sidebar specific objects. I have
>> no suggestions about that right now either, I just wanted to mention
>> it.
>
> Indeed.
>
> My opinion is that their are either part of the tagstore or part of the
> tagtreeview but, in any case, I'm sure they don't belong to the browser
> (where they were).
>
>
> As they are anyway added to the tagstore, I consider that they are parts
> of the model and thus, it makes sense to add them as soon as the
> tagstore is created.
>
> If we don't do that, it would means that the tagstore would be modified
> depending on the view we use to view it ! Which is bad.
>
> Personally, I believe that :
>
> 1) either they belong to the tagstore and, as such, should be created
> with the tagstore and any view of the tagstore can use/see them.
>
> 2) they are part of the view and, thus, should not modify the tagstore
> at all and be special things completely handled by the tagtreeview.
>

My take is that those two pseudo tags are actually UI-objects that
allow the user to display a certain list of tag, but which have no
intrinsic meaning as a data structure. As such, it is for me the
conceptually equivalent of a toolbar button, menu item, or whatever.
They're just displayed in the sidebar treeview because their purpose
is to provide filtering for the task list, and as such, they're
(mostly) functionally equivalent.

That was the reason they were added from the browser in the first
place. I agree they are more specific than the browser, and that they
feel out of place there. Actually I think we should have some sidebar
object, and sidebar tabs object, to decouple the browser from other
task-specific widget and allow to populate the sidebar with other tabs
(much like gedit does). As such, it could be interesting to define
some kind of tag-list "sidebar tab", and that would be where those
pseudo would be handled. Note that it could well be that those pseudo
are not added at all in the tagstore. We could just as well create an
adhoc TreeModel with just those tags.

>
> I've chosen solution 1) because it was the easiest and also because it
> makes sense as the requester himself allows you to get the special tags.
>
> Ok, I admit, mostly because it was the easiest ;-)
>
>
> Lionel
>
>
> _______________________________________________
> Mailing list: https://launchpad.net/~gtg-contributors
> Post to     : gtg-contributors@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~gtg-contributors
> More help   : https://help.launchpad.net/ListHelp
>



-- 
Bertrand Rousseau