gtg-contributors team mailing list archive

[Lionel Dricot <ploum@xxxxxxxxx>]

Le vendredi 26 février 2010 à 12:32 +0100, Bertrand Rousseau a écrit :

> > I'm not really sure because all tags seems to be well in the TagStore.
> > Printing it shows all tags but the treeview doesn't display all.  Maybe
> > they are in the tagstore without sending a signal. Then, it's up to the
> > tagstore to send the signal every time a tag is added.
> 
> You're right. I'm starting to get a grip on this issue. Btw, I saw you
> move the the pseudo tags code to the TagStore. I'm not sure it's the
> best solution since they actually tag-sidebar specific objects. I have
> no suggestions about that right now either, I just wanted to mention
> it.

Indeed.

My opinion is that their are either part of the tagstore or part of the
tagtreeview but, in any case, I'm sure they don't belong to the browser
(where they were).


As they are anyway added to the tagstore, I consider that they are parts
of the model and thus, it makes sense to add them as soon as the
tagstore is created.

If we don't do that, it would means that the tagstore would be modified
depending on the view we use to view it ! Which is bad.

Personally, I believe that :

1) either they belong to the tagstore and, as such, should be created
with the tagstore and any view of the tagstore can use/see them.

2) they are part of the view and, thus, should not modify the tagstore
at all and be special things completely handled by the tagtreeview.



I've chosen solution 1) because it was the easiest and also because it
makes sense as the requester himself allows you to get the special tags.

Ok, I admit, mostly because it was the easiest ;-)


Lionel