← Back to team overview

gtg-contributors team mailing list archive

Re: question on refactoring

 

On Thu, 11 Mar 2010 22:08:17 -1000, Luca Invernizzi
<invernizzi.l@xxxxxxxxx> wrote:
> I just fixed bug https://bugs.edge.launchpad.net/gtg/+bug/529941
> "subtask button creates two subtasks".
>  The bug was caused by these two lines
>   child_task.add_parent(parent_uid)
>   parent_task.add_child(child_task.get_id())
> 
> 
> 
> question:
> In my opinion, those lines  both do the same thing, which resulted in
> having the subtask linked  to the parent twice. Am I correct, or I'm
> missing something? I have yet to pick up fully the "best practices" to
> follow after the refactoring.

I might be wrong but I believe that, before the refactoring, both were
needed to have both references.

Now, it is handled automatically by the Tree, thus it's indeed a bug.



References