gtg-contributors team mailing list archive

[Luca Invernizzi <invernizzi.l@xxxxxxxxx>]

On Mon, Aug 2, 2010 at 6:31 PM, Bryce Harrington <bryce@xxxxxxxxxxxxx> wrote:
> On Fri, Jun 11, 2010 at 05:17:55PM +0200, Luca Invernizzi wrote:
>> FYI, if you want to automatically run tests on commit, give this plugin a shot:
>> http://doc.bazaar.canonical.com/plugins/en/testrunner-plugin.html
>
> Hi, I notice we've got some tests for backend functionality, but should
> we write tests for browser UI functionality?

Eh, the problem is: how? The only toolkit I'm aware of is Mago, and
writing a test seems quite complex. Anyway, the Gedit people have done
that, so maybe it's doable. We have discussed this topic at GUADEC,
and the most viable solution seemed to keep the UI part untested and
as thin as possible.
>
> Also, in gtg/GTG/tests/__init__.py most tests are commented out, but
> there is not an explanation given there - are they broken? or no longer
> relevant?  If the former, we should fix them rather than just disable
> them.  If the latter, then wouldn't it be better to delete the code and
> keep things tidy?  (We have version control if we ever need them again
> some day.)  Or is there some other reason?

The tests are fine. The only reason why they're commented is that the
development in trunk is now concentrated on liblarch, which is the
only uncommented test. Probably, Lionel commented the other tests
while writing the ones for liblarch, and forgot to uncomment them
before committing.

Hi, Bryce!
>
> Bryce
>