gtg-user team mailing list archive

["Lionel Dricot" <ploum@xxxxxxxxx>]

Hey Jonathan,


This is a very good idea as I was not aware about pep8 and I fully commit
to all your proposition.

The reason there's so many warnings is that it's very difficult to get rid
of some stuffs nobody care about and a lot of false positive, especially
when using callbacks.

But it proved to be useful, catching at least two potential bugs where a
variable was not used or changed its name. I welcome all alternative then.

Regarding Tarmac, I've heard about it but I still don't know exactly what
it is and how it works. It looks cool, so I you believe it's useful for
the project, I trust you. If you set up a tarmac instance, maybe it's
better to explain on the wiki what it is and how to use it then.

Lionel


> Hello all,
>
> When running ./scripts/codecheck.sh on a clean copy of trunk, I get a
> lot of warnings. This makes it a little bit harder for me to figure
> out whether a patch I write is actually bad. It would be really,
> really nice if there were zero warnings when running on trunk.
>
> If you think having zero warnings on trunk is a good idea, I'm happy
> to help make it happen. Here's how I would do it:
>
>   * Configure pylint to only check for formatting issues, or ditch it
> in favor of pep8.py
>     In my experience, the only things that pylint catches that
> pyflakes doesn't are things that no one cares about.
>
>   * Start fixing the warnings that are left over, one patch at a time.
>
>   * Put something in the contributor docs saying that new code should
> be PEP 8[1] compliant.
>     A nice thing about using PEP 8 is that it's easier for people who
> work on other Python projects to contribute.
>
>   * (Possibly) Set up a tarmac[2] instance for automated landings such
> that patches that increase the number of warnings are rejected.
>
> I realize I'm very new to GTG, so I'll understand if this proposal
> were to be rejected. However, if you think it's a good idea, I'm happy
> to do the work.
>
> jml
>
> [1] http://www.python.org/dev/peps/pep-0008/
> [2] https://launchpad.net/tarmac
>
> _______________________________________________
> Mailing list: https://launchpad.net/~gtg-user
> Post to     : gtg-user@xxxxxxxxxxxxxxxxxxx
> Unsubscribe : https://launchpad.net/~gtg-user
> More help   : https://help.launchpad.net/ListHelp
>